You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by DoingDone9 <gi...@git.apache.org> on 2014/11/09 15:52:14 UTC

[GitHub] spark pull request: Change the initial iteration num of ruleExecut...

GitHub user DoingDone9 opened a pull request:

    https://github.com/apache/spark/pull/3174

    Change the initial iteration num of ruleExecutor from 1 to 0

    Change the initial iteration num of ruleExecutor from 1 to 0.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DoingDone9/spark catalyst_issue_01

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/3174.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3174
    
----
commit fe0bc4ca5656ba8ec490428748fecc22948b7d95
Author: DoingDone9 <79...@qq.com>
Date:   2014-11-09T14:49:08Z

    Change the first iteration num of ruleExecutor from 1 to 0

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: Change the initial iteration num of ruleExecut...

Posted by DoingDone9 <gi...@git.apache.org>.
Github user DoingDone9 closed the pull request at:

    https://github.com/apache/spark/pull/3174


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: Change the initial iteration num of ruleExecut...

Posted by DoingDone9 <gi...@git.apache.org>.
Github user DoingDone9 commented on the pull request:

    https://github.com/apache/spark/pull/3174#issuecomment-62306218
  
    i am new, but i think it is should be 0 not 1.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: Change the initial iteration num of ruleExecut...

Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:

    https://github.com/apache/spark/pull/3174#issuecomment-62321314
  
    -1 This breaks the logic of the loop. For example if maxIterations is 1, now it will execute twice.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: Change the initial iteration num of ruleExecut...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/3174#issuecomment-62305964
  
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: Change the initial iteration num of ruleExecut...

Posted by DoingDone9 <gi...@git.apache.org>.
Github user DoingDone9 commented on the pull request:

    https://github.com/apache/spark/pull/3174#issuecomment-62471423
  
    @liancheng  because log looks like "Fixed point reached for batch ${batch.name} after 3 iterations.", but it did 2 iterations really! I have pull request a other patch for this, #3180


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: Change the initial iteration num of ruleExecut...

Posted by liancheng <gi...@git.apache.org>.
Github user liancheng commented on the pull request:

    https://github.com/apache/spark/pull/3174#issuecomment-62352269
  
    Agree with @srowen. @DoingDone9 Could you please elaborate on the reason why you think this change is necessary?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org