You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by rp...@apache.org on 2018/10/31 06:45:39 UTC
svn commit: r1845312 - /subversion/trunk/tools/dist/backport.pl
Author: rpluem
Date: Wed Oct 31 06:45:39 2018
New Revision: 1845312
URL: http://svn.apache.org/viewvc?rev=1845312&view=rev
Log:
Adjust grep syntax to be able to run it with Perl 5.16.3.
* tools/dist/backport.pl
(vote) Adjust grep syntax to be able to run it with Perl 5.16.3.
[D:other] backport.pl: Make it run with Perl 5.16.3.
Modified:
subversion/trunk/tools/dist/backport.pl
Modified: subversion/trunk/tools/dist/backport.pl
URL: http://svn.apache.org/viewvc/subversion/trunk/tools/dist/backport.pl?rev=1845312&r1=1845311&r2=1845312&view=diff
==============================================================================
--- subversion/trunk/tools/dist/backport.pl (original)
+++ subversion/trunk/tools/dist/backport.pl Wed Oct 31 06:45:39 2018
@@ -791,7 +791,7 @@ sub vote {
# Add to state votes that aren't '+0' or 'edit'
$state->{$_->{digest}}++ for grep
- ($_->{approval} or $_->{vote} =~ /^(-1|-0|[+]1)$/),
+ +($_->{approval} or $_->{vote} =~ /^(-1|-0|[+]1)$/),
@votesarray;
}
}
Re: svn commit: r1845312 - /subversion/trunk/tools/dist/backport.pl
Posted by Ruediger Pluem <rp...@apache.org>.
On 2018/10/31 06:54:35, Daniel Shahaf <d....@daniel.shahaf.name> wrote:
> Good morning Ruediger,
>
> rpluem@apache.org wrote on Wed, 31 Oct 2018 06:45 +0000:
> > Adjust grep syntax to be able to run it with Perl 5.16.3.
> >
> > * tools/dist/backport.pl
> > (vote) Adjust grep syntax to be able to run it with Perl 5.16.3.
> >
> > [D:other] backport.pl: Make it run with Perl 5.16.3.
>
> Thanks for committing the fix.
>
> In CHANGES, "developer-visible" means "visible to API consumers".
> backport.pl, however, is not visible to API consumers; it's only used
> by developers working on Subversion itself. As such, this changelog
> line, although syntactically correct, is wrong. The correct line would
> be [c:skip].
Ahh, sorry. Makes sense. I misunderstood the comments in release.py regarding D:
>
> I'll go ahead and make it so.
Thanks
Regards
RĂ¼diger
Re: svn commit: r1845312 - /subversion/trunk/tools/dist/backport.pl
Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Good morning Ruediger,
rpluem@apache.org wrote on Wed, 31 Oct 2018 06:45 +0000:
> Adjust grep syntax to be able to run it with Perl 5.16.3.
>
> * tools/dist/backport.pl
> (vote) Adjust grep syntax to be able to run it with Perl 5.16.3.
>
> [D:other] backport.pl: Make it run with Perl 5.16.3.
Thanks for committing the fix.
In CHANGES, "developer-visible" means "visible to API consumers".
backport.pl, however, is not visible to API consumers; it's only used
by developers working on Subversion itself. As such, this changelog
line, although syntactically correct, is wrong. The correct line would
be [c:skip].
I'll go ahead and make it so.
Cheers,
Daniel
Re: svn commit: r1845312 - /subversion/trunk/tools/dist/backport.pl
Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Good morning Ruediger,
rpluem@apache.org wrote on Wed, 31 Oct 2018 06:45 +0000:
> Adjust grep syntax to be able to run it with Perl 5.16.3.
>
> * tools/dist/backport.pl
> (vote) Adjust grep syntax to be able to run it with Perl 5.16.3.
>
> [D:other] backport.pl: Make it run with Perl 5.16.3.
Thanks for committing the fix.
In CHANGES, "developer-visible" means "visible to API consumers".
backport.pl, however, is not visible to API consumers; it's only used
by developers working on Subversion itself. As such, this changelog
line, although syntactically correct, is wrong. The correct line would
be [c:skip].
I'll go ahead and make it so.
Cheers,
Daniel