You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Øystein Grøvlen (JIRA)" <de...@db.apache.org> on 2006/09/27 16:13:51 UTC
[jira] Created: (DERBY-1893) Convert largedata/lobLengthTests.java
to junit
Convert largedata/lobLengthTests.java to junit
----------------------------------------------
Key: DERBY-1893
URL: http://issues.apache.org/jira/browse/DERBY-1893
Project: Derby
Issue Type: Sub-task
Components: Test
Reporter: Øystein Grøvlen
Assigned To: Øystein Grøvlen
Priority: Trivial
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] Commented: (DERBY-1893) Convert
largedata/lobLengthTests.java to junit
Posted by "Bernt M. Johnsen" <Be...@Sun.COM>.
>>>>>>>>>>>> Bernt M. Johnsen wrote (2006-10-09 11:24:55):
> >>>>>>>>>>>> Dyre Tjeldvoll (JIRA) wrote (2006-10-09 02:09:20):
> > [ http://issues.apache.org/jira/browse/DERBY-1893?page=comments#action_12440834 ]
> >
> > Dyre Tjeldvoll commented on DERBY-1893:
> > ---------------------------------------
> >
> > Patch looks good.
> > +1 to commit
>
> I'll commit it.
The patch does not apply cleanly in trunk.
--
Bernt Marius Johnsen, Database Technology Group,
Staff Engineer, Technical Lead Derby/Java DB
Sun Microsystems, Trondheim, Norway
Re: [jira] Commented: (DERBY-1893) Convert
largedata/lobLengthTests.java to junit
Posted by "Bernt M. Johnsen" <Be...@Sun.COM>.
>>>>>>>>>>>> Dyre Tjeldvoll (JIRA) wrote (2006-10-09 02:09:20):
> [ http://issues.apache.org/jira/browse/DERBY-1893?page=comments#action_12440834 ]
>
> Dyre Tjeldvoll commented on DERBY-1893:
> ---------------------------------------
>
> Patch looks good.
> +1 to commit
I'll commit it.
>
> > Convert largedata/lobLengthTests.java to junit
> > ----------------------------------------------
> >
> > Key: DERBY-1893
> > URL: http://issues.apache.org/jira/browse/DERBY-1893
> > Project: Derby
> > Issue Type: Sub-task
> > Components: Test
> > Reporter: Øystein Grøvlen
> > Assigned To: Øystein Grøvlen
> > Priority: Trivial
> > Attachments: derby1893.diff, derby1893.stat
> >
> >
>
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
--
Bernt Marius Johnsen, Database Technology Group,
Staff Engineer, Technical Lead Derby/Java DB
Sun Microsystems, Trondheim, Norway
[jira] Resolved: (DERBY-1893) Convert largedata/lobLengthTests.java
to junit
Posted by "Bernt M. Johnsen (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1893?page=all ]
Bernt M. Johnsen resolved DERBY-1893.
-------------------------------------
Resolution: Fixed
Derby Info: (was: [Patch Available])
Committed revision 464504.
> Convert largedata/lobLengthTests.java to junit
> ----------------------------------------------
>
> Key: DERBY-1893
> URL: http://issues.apache.org/jira/browse/DERBY-1893
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Reporter: Øystein Grøvlen
> Assigned To: Øystein Grøvlen
> Priority: Trivial
> Attachments: derby1893.diff, derby1893.stat, derby1893_v2.diff, derby1893_v2.stat
>
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1893) Convert
largedata/lobLengthTests.java to junit
Posted by "Daniel John Debrunner (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1893?page=comments#action_12442685 ]
Daniel John Debrunner commented on DERBY-1893:
----------------------------------------------
I was actually addressing the issues that Knut Anders raises in some cleanup related to DERBY-1952
> Convert largedata/lobLengthTests.java to junit
> ----------------------------------------------
>
> Key: DERBY-1893
> URL: http://issues.apache.org/jira/browse/DERBY-1893
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Reporter: Øystein Grøvlen
> Assigned To: Øystein Grøvlen
> Priority: Trivial
> Attachments: derby1893.diff, derby1893.stat, derby1893_v2.diff, derby1893_v2.stat
>
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-1893) Convert largedata/lobLengthTests.java
to junit
Posted by "Øystein Grøvlen (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1893?page=all ]
Øystein Grøvlen updated DERBY-1893:
-----------------------------------
Attachment: derby1893.diff
derby1893.stat
derby1893.diff contains the changes to port the test
largedata/lobLengthTests.java to junit. The test has been renamed to
LobLengthTest to follow what seems to be the standard naming pattern
for Derby Junit tests. I have also moved the test from largedata to jdbcapi
and included it in the standard test suite since it seems that an
extra large heap is no longer needed to run this test. The following
files are affected by this patch:
D java/testing/org/apache/derbyTesting/functionTests/tests/largedata/lobLengthTests.java
Old test is removed
D java/testing/org/apache/derbyTesting/functionTests/tests/largedata/lobLengthTests_app.properties
No need for larger heap size anymore.
M java/testing/org/apache/derbyTesting/functionTests/tests/largedata/copyfiles.ant
No properties file to copy anymore.
M java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/_Suite.java
Adds the test to the jdbcapi junit test suite.
A java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/LobLengthTest.java
Converted test.
M java/testing/org/apache/derbyTesting/functionTests/suites/largeDataTests.runall
Removed test from largedata suite
derbyall has been run with no failures.
> Convert largedata/lobLengthTests.java to junit
> ----------------------------------------------
>
> Key: DERBY-1893
> URL: http://issues.apache.org/jira/browse/DERBY-1893
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Reporter: Øystein Grøvlen
> Assigned To: Øystein Grøvlen
> Priority: Trivial
> Attachments: derby1893.diff, derby1893.stat
>
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1893) Convert
largedata/lobLengthTests.java to junit
Posted by "Knut Anders Hatlen (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1893?page=comments#action_12442681 ]
Knut Anders Hatlen commented on DERBY-1893:
-------------------------------------------
I have two comments to the patch (sorry I didn't notice before it was committed):
- the suite method should have used suite.addTestSuite(LobLengthTest.class) instead of suite.addTest(new LobLengthTest("testXXX")). The way it is now, a new test case won't run automatically, and one might be led to belive that it succeeded when in fact it did not run.
- the tearDown() method should set conn to null and call super.tearDown(). Tests not doing this have caused OutOfMemoryErrors before (DERBY-1845 and DERBY-1910). (It would be even better if the test class didn't have its own instance variable for the connection since the BaseJDBCTestClass already has many helper methods which remove the need for an explicit pointer to the connection.)
> Convert largedata/lobLengthTests.java to junit
> ----------------------------------------------
>
> Key: DERBY-1893
> URL: http://issues.apache.org/jira/browse/DERBY-1893
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Reporter: Øystein Grøvlen
> Assigned To: Øystein Grøvlen
> Priority: Trivial
> Attachments: derby1893.diff, derby1893.stat, derby1893_v2.diff, derby1893_v2.stat
>
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-1893) Convert largedata/lobLengthTests.java
to junit
Posted by "Øystein Grøvlen (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1893?page=all ]
Øystein Grøvlen updated DERBY-1893:
-----------------------------------
Derby Info: [Patch Available]
> Convert largedata/lobLengthTests.java to junit
> ----------------------------------------------
>
> Key: DERBY-1893
> URL: http://issues.apache.org/jira/browse/DERBY-1893
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Reporter: Øystein Grøvlen
> Assigned To: Øystein Grøvlen
> Priority: Trivial
> Attachments: derby1893.diff, derby1893.stat
>
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-1893) Convert largedata/lobLengthTests.java
to junit
Posted by "Øystein Grøvlen (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1893?page=all ]
Øystein Grøvlen updated DERBY-1893:
-----------------------------------
Attachment: derby1893_v2.diff
derby1893_v2.stat
I have attached new versions of the patch and the stat output, derby1893_v2*.
The patch is regenerated at the current head of trunk. In addition, I have
removed the master file for the old test as pointed out by Fernanda.
> Convert largedata/lobLengthTests.java to junit
> ----------------------------------------------
>
> Key: DERBY-1893
> URL: http://issues.apache.org/jira/browse/DERBY-1893
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Reporter: Øystein Grøvlen
> Assigned To: Øystein Grøvlen
> Priority: Trivial
> Attachments: derby1893.diff, derby1893.stat, derby1893_v2.diff, derby1893_v2.stat
>
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (DERBY-1893) Convert largedata/lobLengthTests.java
to junit
Posted by "Øystein Grøvlen (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1893?page=all ]
Øystein Grøvlen closed DERBY-1893.
----------------------------------
Thanks to Bernt for committing the patch, and to Dan for improving it wrt to junit issues.
> Convert largedata/lobLengthTests.java to junit
> ----------------------------------------------
>
> Key: DERBY-1893
> URL: http://issues.apache.org/jira/browse/DERBY-1893
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Reporter: Øystein Grøvlen
> Assigned To: Øystein Grøvlen
> Priority: Trivial
> Attachments: derby1893.diff, derby1893.stat, derby1893_v2.diff, derby1893_v2.stat
>
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1893) Convert
largedata/lobLengthTests.java to junit
Posted by "Dyre Tjeldvoll (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1893?page=comments#action_12440834 ]
Dyre Tjeldvoll commented on DERBY-1893:
---------------------------------------
Patch looks good.
+1 to commit
> Convert largedata/lobLengthTests.java to junit
> ----------------------------------------------
>
> Key: DERBY-1893
> URL: http://issues.apache.org/jira/browse/DERBY-1893
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Reporter: Øystein Grøvlen
> Assigned To: Øystein Grøvlen
> Priority: Trivial
> Attachments: derby1893.diff, derby1893.stat
>
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1893) Convert
largedata/lobLengthTests.java to junit
Posted by "Fernanda Pizzorno (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1893?page=comments#action_12440854 ]
Fernanda Pizzorno commented on DERBY-1893:
------------------------------------------
Shouldn't the master file (java/testing/org/apache/derbyTesting/functionTests/master/lobLengthTests.out) be deleted?
> Convert largedata/lobLengthTests.java to junit
> ----------------------------------------------
>
> Key: DERBY-1893
> URL: http://issues.apache.org/jira/browse/DERBY-1893
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Reporter: Øystein Grøvlen
> Assigned To: Øystein Grøvlen
> Priority: Trivial
> Attachments: derby1893.diff, derby1893.stat
>
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira