You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/09/07 21:08:00 UTC

[jira] [Commented] (HUDI-96) Use Command line options instead of positional arguments when launching spark applications from various CLI commands

    [ https://issues.apache.org/jira/browse/HUDI-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411491#comment-17411491 ] 

ASF GitHub Bot commented on HUDI-96:
------------------------------------

vinothchandar closed pull request #1174:
URL: https://github.com/apache/hudi/pull/1174


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Use Command line options instead of positional arguments when launching spark applications from various CLI commands
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: HUDI-96
>                 URL: https://issues.apache.org/jira/browse/HUDI-96
>             Project: Apache Hudi
>          Issue Type: Improvement
>          Components: CLI, newbie
>            Reporter: Balaji Varadarajan
>            Assignee: Pratyaksh Sharma
>            Priority: Minor
>              Labels: newbie, pull-request-available, sev:normal, user-support-issues
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Hoodie CLI commands like compaction/rollback/repair/savepoints/parquet-import relies on launching a spark application to perform their operations (look at SparkMain.java). 
> SparkMain (Look at SparkMain.main()) relies on positional arguments for passing  various CLI options. Instead we should define proper CLI options in SparkMain and use them (using Jcommander)  to improve readability and avoid accidental errors at call sites. For e.g : See com.uber.hoodie.utilities.HoodieCompactor



--
This message was sent by Atlassian Jira
(v8.3.4#803005)