[GitHub] [incubator-doris] wangbo commented on a change in pull request #2781: Batch Operate Rollup table in Doris #2671

[GitBox <gi...@apache.org>]

wangbo commented on a change in pull request #2781: Batch Operate Rollup table in Doris #2671
URL: https://github.com/apache/incubator-doris/pull/2781#discussion_r367853030
 
 

 ##########
 File path: fe/src/main/cup/sql_parser.cup
 ##########
 @@ -2276,14 +2328,24 @@ cancel_stmt ::=
     :}
     ;
 
+cancel_rollup_job_id_list ::=
 
 Review comment:
   When user want to cancel job,he must first to execute "show alter table rollup" to get job info and find the job to be cancel,then use job info(jobid or rollup name) to cancel a job;
   In my opinion,use rollup name isn't better than using jobid;In contrast, rollup name may be too long to cause alter sql too long.
   Do you have some good reason to use rollup name?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org