[GitHub] [helix] dasahcc commented on a change in pull request #909: Created generic get and update methods for Cluster and REST config

[GitBox <gi...@apache.org>]

dasahcc commented on a change in pull request #909: Created generic get and update methods for Cluster and REST config
URL: https://github.com/apache/helix/pull/909#discussion_r400505452
 
 

 ##########
 File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/ClusterAccessor.java
 ##########
 @@ -671,4 +559,85 @@ private boolean doesClusterExist(String cluster) {
     }
     return history;
   }
+
+  private Response updateConfig(String clusterId, String commandStr, String content,
 
 Review comment:
   That is a good refactoring. Just a nit suggestion, maybe we can move this to a Util class and apply to all other configs operations for different REST accessors such as ResourceConfig, InstanceConfig and so on.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org