[GitHub] [pinot] tibrewalpratik17 commented on a diff in pull request #10725: Minor Realtime Segment Commit Upload Improvements

["tibrewalpratik17 (via GitHub)" <gi...@apache.org>]

tibrewalpratik17 commented on code in PR #10725:
URL: https://github.com/apache/pinot/pull/10725#discussion_r1187719895


##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/PinotFSSegmentUploader.java:
##########
@@ -96,9 +96,8 @@ public URI uploadSegment(File segmentFile, LLCSegmentName segmentName) {
       LOGGER.info("Interrupted while waiting for segment upload of {} to {}.", segmentName, _segmentStoreUriStr);
       Thread.currentThread().interrupt();
     } catch (TimeoutException e) {
-      _serverMetrics.addMeteredTableValue(segmentName.getTableName(), ServerMeter.SEGMENT_UPLOAD_TIMEOUT, 1);
-      LOGGER.warn("Timed out waiting to upload segment: {} for table: {}",
-          segmentName.getSegmentName(), segmentName.getTableName());
+      _serverMetrics.addMeteredTableValue(rawTableName, ServerMeter.SEGMENT_UPLOAD_TIMEOUT, 1);

Review Comment:
   @ankitsultana  Should we also emit metric for segment upload success / failure overall? This is not related to this PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org