[GitHub] [spark] srowen commented on a change in pull request #34895: [SPARK-6305][BUILD] Migrate from log4j1 to log4j2

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #34895:
URL: https://github.com/apache/spark/pull/34895#discussion_r772066437



##########
File path: launcher/src/test/java/org/apache/spark/launcher/ChildProcAppHandleSuite.java
##########
@@ -238,22 +242,29 @@ String findSparkSubmit() {
    * A log4j appender used by child apps of this test. It records all messages logged through it in
    * memory so the test can check them.
    */
-  public static class LogAppender extends AppenderSkeleton {
-
-    @Override
-    protected void append(LoggingEvent event) {
-      MESSAGES.add(event.getMessage().toString());
+  @Plugin(name="LogAppender", category="Core", elementType="appender", printObject=true)
+  public static class LogAppender extends AbstractAppender {
+
+    protected LogAppender(String name,
+                          Filter filter,

Review comment:
       Indent seems fine here




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org