You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2015/12/15 11:59:51 UTC
[GitHub] flink pull request: [FLINK-3165] [py] Windows OS support
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/1454
[FLINK-3165] [py] Windows OS support
This PR allows the usage of the Python API on the Windows Operating System.
Essentially, 4 changes were made:
* pyflinkX.bat start scripts were added
* all paths were adjusted to work with both Unix and Windows systems
* python files on the jobmanager are stored in a randomized folder
* overlapping python jobs used the same directory, causing data corruption
* usages of socket.recv(\<toRead\>, socket.MSG_WAITALL) were replaced with a new method
* MSG_WAITALL flag is not available on windows
* Note: the flag ensured that recv() returned exactly n bytes, opposed to the default of *up to* n bytes
In addition, several resources are now properly closed in python and error reporting has been improved.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 3165_py4windows
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1454.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1454
----
commit 605fb53edf8c8076a7fa81f809776a8492c6145a
Author: zentol <ch...@apache.org>
Date: 2015-12-15T08:38:04Z
[FLINK-3165] [py] Windows OS support
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3165] [py] Windows OS support
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1454#issuecomment-167453524
I haven't used it a lot yet which is why i didn't add it to the ducomentation yet, but the examples & tests seem to work. I am developing on windows now and should run into issues if there are any.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3165] [py] Windows OS support
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1454
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3165] [py] Windows OS support
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1454#issuecomment-167420372
@zentol From a first glance, the change looks good.
If you have tested this properly on Windows and are confident that this works, I would go ahead and merge this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3165] [py] Windows OS support
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1454#issuecomment-171789939
Please merge at your own discretion!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---