You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sqoop.apache.org by Bilung Lee <bl...@gmail.com> on 2011/11/03 20:49:56 UTC

Review Request: SQOOP-388 Add license header to Hive testdata

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2716/
-----------------------------------------------------------

Review request for Sqoop and Arvind Prabhakar.


Summary
-------

Patch for SQOOP-388.


This addresses bug SQOOP-388.
    https://issues.apache.org/jira/browse/SQOOP-388


Diffs
-----

  ./testdata/hive/bin/hive 1187139 
  ./testdata/hive/scripts/createOnlyImport.q 1196702 
  ./testdata/hive/scripts/createOverwriteImport.q 1196702 
  ./testdata/hive/scripts/customDelimImport.q 1196702 
  ./testdata/hive/scripts/dateImport.q 1196701 
  ./testdata/hive/scripts/failingImport.q 1196702 
  ./testdata/hive/scripts/fieldWithNewlineImport.q 1196702 
  ./testdata/hive/scripts/fieldWithNewlineReplacementImport.q 1196702 
  ./testdata/hive/scripts/normalImport.q 1196702 
  ./testdata/hive/scripts/numericImport.q 1196702 
  ./testdata/hive/scripts/partitionImport.q 1196702 

Diff: https://reviews.apache.org/r/2716/diff


Testing
-------


Thanks,

Bilung

Re: Review Request: SQOOP-388 Add license header to Hive testdata

Posted by Arvind Prabhakar <ar...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2716/#review3041
-----------------------------------------------------------

Ship it!


+1

Changes look good. Please attach the patch to JIRA.

- Arvind


On 2011-11-03 19:49:56, Bilung Lee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2716/
> -----------------------------------------------------------
> 
> (Updated 2011-11-03 19:49:56)
> 
> 
> Review request for Sqoop and Arvind Prabhakar.
> 
> 
> Summary
> -------
> 
> Patch for SQOOP-388.
> 
> 
> This addresses bug SQOOP-388.
>     https://issues.apache.org/jira/browse/SQOOP-388
> 
> 
> Diffs
> -----
> 
>   ./testdata/hive/bin/hive 1187139 
>   ./testdata/hive/scripts/createOnlyImport.q 1196702 
>   ./testdata/hive/scripts/createOverwriteImport.q 1196702 
>   ./testdata/hive/scripts/customDelimImport.q 1196702 
>   ./testdata/hive/scripts/dateImport.q 1196701 
>   ./testdata/hive/scripts/failingImport.q 1196702 
>   ./testdata/hive/scripts/fieldWithNewlineImport.q 1196702 
>   ./testdata/hive/scripts/fieldWithNewlineReplacementImport.q 1196702 
>   ./testdata/hive/scripts/normalImport.q 1196702 
>   ./testdata/hive/scripts/numericImport.q 1196702 
>   ./testdata/hive/scripts/partitionImport.q 1196702 
> 
> Diff: https://reviews.apache.org/r/2716/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bilung
> 
>