You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "unbridled-41 (via GitHub)" <gi...@apache.org> on 2026/10/09 21:02:08 UTC
[PR] docs(deploy): the demo producer and consumer do not go through the proxy [rocketmq-dashboard]
unbridled-41 opened a new pull request, #5971:
URL: https://github.com/apache/rocketmq-dashboard/pull/5971
### Which Issue(s) This PR Fixes
Fixes #5970
### Problem / Evidence
`deploy/rocketmq/README.md` lines 20-21 said both generators connect via `proxy:8080`, while `clients/TraceProducer.java:7` / `TraceConsumer.java:8` read `NAMESRV_ADDR` and `docker-compose.yml` passes `rmq-nameserver:9876` to both. Its own comments say 直连 NameServer, the runbook agrees, and no client reads a proxy or gRPC endpoint.
### Root cause / Fix
Stale directory comment from an earlier proxy-mode plan; correct it to name the NameServer connection.
### Priority and scoring
**PRIORITY 45** - impact 12/40 (misleading orientation, no code impact), blast radius 8/20 (the demo stack), reproducibility 20/20 (grep), maintenance value 5/20. **FIX_CONFIDENCE 90**.
### Tests
Documentation only; verified with `grep -n "NAMESRV_ADDR\|setNamesrvAddr" deploy/rocketmq/clients/*.java deploy/rocketmq/docker-compose.yml` (every client/container uses the NameServer) and `grep -rn "proxy\|8080" deploy/rocketmq/clients/` (no hits).
### Risk
None.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs(deploy): the demo producer and consumer do not go through the proxy [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5971:
URL: https://github.com/apache/rocketmq-dashboard/pull/5971#issuecomment-6227220999
This pull request has been automatically closed because there has been no activity for 7 days. If you would like to continue working on this, please reopen the PR with updated changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs(deploy): the demo producer and consumer do not go through the proxy [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #5971: docs(deploy): the demo producer and consumer do not go through the proxy
URL: https://github.com/apache/rocketmq-dashboard/pull/5971
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs(deploy): the demo producer and consumer do not go through the proxy [rocketmq-dashboard]
Posted by "unbridled-41 (via GitHub)" <gi...@apache.org>.
unbridled-41 commented on PR #5971:
URL: https://github.com/apache/rocketmq-dashboard/pull/5971#issuecomment-6090241586
### CI status of this PR
`Backend Tests (Java 21)` — see the note below the list.
The four remaining red jobs are red for every branch, including `rocketmq-studio` itself:
- `Backend Build (Java 21)` — the `binary-license-gate` antrun step fails on a list of third-party jars (`spring-ai-*`, `swagger-ui`, `tencentcloud-sdk-*`, `zstd-jni`, ... : "missing complete upstream LICENSE/COPYING; a POM name or link is not a substitute"). This PR touches no build configuration; tracked by #5341.
- `Frontend Build (Node 20)` / `Frontend Docker Build` — the frontend licence manifest check fails the same way on branches that do not touch `web/` at all; tracked by #5346.
- `rmqctl Build (Go)` — `cmd` `TestMessageQueryCompletenessWarningTest` yaml subtests: `got {"items":[{"size":"3",...}]}, want {"size":3,...}`, i.e. the YAML renderer writes numbers as quoted strings where the test expects integer literals. Reproduced locally with `cd rmqctl && go test ./cmd/` from a checkout whose `rmqctl/` tree is byte-identical to `rocketmq-studio`'s, and owned by open PR #5850 ("keep yaml numbers unquoted").
`Backend Tests (Java 21)` failure attribution: `ResourceOwnershipGuardTest.migrationConcurrentStartupIsIdempotentTest` — `org.h2.jdbc.JdbcSQLNonTransientException: General error: java.util.ConcurrentModificationException` — the known flaky H2 concurrency test tracked by #5302. It reproduces independently of this diff (which touches no persistence code) and the same job passes on sibling PRs of the same batch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs(deploy): the demo producer and consumer do not go through the proxy [rocketmq-dashboard]
Posted by "unbridled-41 (via GitHub)" <gi...@apache.org>.
unbridled-41 commented on PR #5971:
URL: https://github.com/apache/rocketmq-dashboard/pull/5971#issuecomment-6091393916
### Verification on the final commit (branch + commit + command results)
Every command from the description re-run on a fresh worktree of this branch (`git worktree add <dir> fork/<branch>`, no local modifications), at commit `745c39e068`:
| command | exit | result |
| --- | --- | --- |
| `grep -n "NAMESRV_ADDR\|setNamesrvAddr" deploy/rocketmq/clients/*.java deploy/rocketmq/docker-compose.yml` | 0 | `deploy/rocketmq/docker-compose.yml:84: NAMESRV_ADDR: rmq-nameserver:9876 / deploy/rocketmq/docker-compose.yml:102: NAMESRV_ADDR: rmq-nameserver:9876` |
| `grep -rn "proxy\|8080" deploy/rocketmq/clients/` | 1 | `` |
> Non-zero exits above are from the verification commands this PR states (a negative `grep` with no matches, or a check whose non-zero exit *is* the documented result); the observed output is quoted verbatim.
CI note: on this repository the `Backend Build` (binary-license-gate), `Frontend Build` / `Frontend Docker Build` (licence manifest) and `rmqctl Build` (YAML renderer quoting) jobs are red for every branch, trunk included; the module-level commands above are unaffected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org