[GitHub] [airflow] ktmud commented on a change in pull request #7088: [WIP][AIRFLOW-6494] SSH host_proxy has to be fresh

[GitBox <gi...@apache.org>]

ktmud commented on a change in pull request #7088: [WIP][AIRFLOW-6494] SSH host_proxy has to be fresh
URL: https://github.com/apache/airflow/pull/7088#discussion_r365569433
 
 

 ##########
 File path: airflow/contrib/hooks/ssh_hook.py
 ##########
 @@ -90,14 +90,10 @@ def __init__(self,
         # Use connection to override defaults
         if self.ssh_conn_id is not None:
             conn = self.get_connection(self.ssh_conn_id)
-            if self.username is None:
-                self.username = conn.login
-            if self.password is None:
-                self.password = conn.password
-            if self.remote_host is None:
-                self.remote_host = conn.host
-            if self.port is None:
-                self.port = conn.port
+            self.username = conn.login
 
 Review comment:
   My bad. Thought I saw those values being initialized as None at __init__. Must be from some other revision.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services