You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Peter Rozsa (Code Review)" <ge...@cloudera.org> on 2026/02/06 14:17:48 UTC
[Impala-ASF-CR] IMPALA-14683: remove AES 128 GCM test case from encryption exprs errors
Peter Rozsa has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23947
Change subject: IMPALA-14683: remove AES_128_GCM test case from encryption_exprs_errors
......................................................................
IMPALA-14683: remove AES_128_GCM test case from encryption_exprs_errors
This change removes AES_128_GCM aes_decrypt test case as the AES_256_GCM
checks the same code path and therefore it gives no additional value.
This test could have failed on systems where the openssl version already
deprecated the AES_128_GCM mode.
Change-Id: If6cf709d6e16a8d0e70037d4545c9de12cacf251
---
M testdata/workloads/functional-query/queries/QueryTest/encryption_exprs_errors.test
1 file changed, 0 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/47/23947/1
--
To view, visit http://gerrit.cloudera.org:8080/23947
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If6cf709d6e16a8d0e70037d4545c9de12cacf251
Gerrit-Change-Number: 23947
Gerrit-PatchSet: 1
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
[Impala-ASF-CR] IMPALA-14683: remove AES 128 GCM test case from encryption exprs errors
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/23947 )
Change subject: IMPALA-14683: remove AES_128_GCM test case from encryption_exprs_errors
......................................................................
Patch Set 1: Code-Review+2
Thanks for fixing it!
--
To view, visit http://gerrit.cloudera.org:8080/23947
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If6cf709d6e16a8d0e70037d4545c9de12cacf251
Gerrit-Change-Number: 23947
Gerrit-PatchSet: 1
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Feb 2026 15:36:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14683: remove AES 128 GCM test case from encryption exprs errors
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23947 )
Change subject: IMPALA-14683: remove AES_128_GCM test case from encryption_exprs_errors
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/23947
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If6cf709d6e16a8d0e70037d4545c9de12cacf251
Gerrit-Change-Number: 23947
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Feb 2026 15:39:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14683: remove AES 128 GCM test case from encryption exprs errors
Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/23947 )
Change subject: IMPALA-14683: remove AES_128_GCM test case from encryption_exprs_errors
......................................................................
Patch Set 2: Verified+1
Unrelated flaky test failure in https://jenkins.impala.io/job/ubuntu-20.04-from-scratch/7994/testReport/junit/authorization.test_ranger/TestRangerIndependent/test_allow_metadata_update_local_catalog/
--
To view, visit http://gerrit.cloudera.org:8080/23947
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If6cf709d6e16a8d0e70037d4545c9de12cacf251
Gerrit-Change-Number: 23947
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Feb 2026 10:21:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14683: remove AES 128 GCM test case from encryption exprs errors
Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has removed a vote on this change.
Change subject: IMPALA-14683: remove AES_128_GCM test case from encryption_exprs_errors
......................................................................
Removed Verified-1 by Impala Public Jenkins <im...@cloudera.com>
--
To view, visit http://gerrit.cloudera.org:8080/23947
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: If6cf709d6e16a8d0e70037d4545c9de12cacf251
Gerrit-Change-Number: 23947
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-14683: remove AES 128 GCM test case from encryption exprs errors
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23947 )
Change subject: IMPALA-14683: remove AES_128_GCM test case from encryption_exprs_errors
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/13049/
--
To view, visit http://gerrit.cloudera.org:8080/23947
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If6cf709d6e16a8d0e70037d4545c9de12cacf251
Gerrit-Change-Number: 23947
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Feb 2026 20:30:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14683: remove AES 128 GCM test case from encryption exprs errors
Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23947 )
Change subject: IMPALA-14683: remove AES_128_GCM test case from encryption_exprs_errors
......................................................................
IMPALA-14683: remove AES_128_GCM test case from encryption_exprs_errors
This change removes AES_128_GCM aes_decrypt test case as the AES_256_GCM
checks the same code path and therefore it gives no additional value.
This test could have failed on systems where the openssl version already
deprecated the AES_128_GCM mode.
Change-Id: If6cf709d6e16a8d0e70037d4545c9de12cacf251
Reviewed-on: http://gerrit.cloudera.org:8080/23947
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Peter Rozsa <pr...@cloudera.com>
---
M testdata/workloads/functional-query/queries/QueryTest/encryption_exprs_errors.test
1 file changed, 0 insertions(+), 6 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved
Peter Rozsa: Verified
--
To view, visit http://gerrit.cloudera.org:8080/23947
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If6cf709d6e16a8d0e70037d4545c9de12cacf251
Gerrit-Change-Number: 23947
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-14683: remove AES 128 GCM test case from encryption exprs errors
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23947 )
Change subject: IMPALA-14683: remove AES_128_GCM test case from encryption_exprs_errors
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/21592/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/23947
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If6cf709d6e16a8d0e70037d4545c9de12cacf251
Gerrit-Change-Number: 23947
Gerrit-PatchSet: 1
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Feb 2026 14:42:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14683: remove AES 128 GCM test case from encryption exprs errors
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23947 )
Change subject: IMPALA-14683: remove AES_128_GCM test case from encryption_exprs_errors
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13049/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/23947
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If6cf709d6e16a8d0e70037d4545c9de12cacf251
Gerrit-Change-Number: 23947
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Feb 2026 15:39:32 +0000
Gerrit-HasComments: No