You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/02/19 01:07:52 UTC

[GitHub] [hadoop-ozone] bharatviswa504 opened a new pull request #564: HDDS-3031. OM HA- Client requests get LeaderNotReadyException after OM's restart.

bharatviswa504 opened a new pull request #564: HDDS-3031. OM HA- Client requests get LeaderNotReadyException after OM's restart.
URL: https://github.com/apache/hadoop-ozone/pull/564
 
 
   ## What changes were proposed in this pull request?
   
   Fix LeaderNotReady exception which is thrown for write requests after OM restarts.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-3031
   
   ## How was this patch tested?
   
   Deployed on the cluster and tried the scenario. With the PR fix, now able to execute client requests after OM restart.
   
   I will see if I can add UT for this.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] hanishakoneru commented on a change in pull request #564: HDDS-3031. OM HA- Client requests get LeaderNotReadyException after OM's restart.

Posted by GitBox <gi...@apache.org>.
hanishakoneru commented on a change in pull request #564: HDDS-3031. OM HA- Client requests get LeaderNotReadyException after OM's restart.
URL: https://github.com/apache/hadoop-ozone/pull/564#discussion_r381458280
 
 

 ##########
 File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/volume/OMVolumeCreateRequest.java
 ##########
 @@ -164,7 +164,7 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
           // Replay implies the response has already been returned to
           // the client. So take no further action and return a dummy
           // OMClientResponse.
-          LOG.debug("Replayed Transaction {} ignored. Request: {}",
+          LOG.info("Replayed Transaction {} ignored. Request: {}",
 
 Review comment:
   Keeping this log message at info level will flood the log file. It prints the Request body also.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] bharatviswa504 commented on issue #564: HDDS-3031. OM HA- Client requests get LeaderNotReadyException after OM's restart.

Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on issue #564: HDDS-3031. OM HA- Client requests get LeaderNotReadyException after OM's restart.
URL: https://github.com/apache/hadoop-ozone/pull/564#issuecomment-588431146
 
 
   Thank You @hanishakoneru for the review.
   Addressed review comments.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] hanishakoneru commented on a change in pull request #564: HDDS-3031. OM HA- Client requests get LeaderNotReadyException after OM's restart.

Posted by GitBox <gi...@apache.org>.
hanishakoneru commented on a change in pull request #564: HDDS-3031. OM HA- Client requests get LeaderNotReadyException after OM's restart.
URL: https://github.com/apache/hadoop-ozone/pull/564#discussion_r381460743
 
 

 ##########
 File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/multipart/S3InitiateMultipartUploadRequest.java
 ##########
 @@ -203,11 +203,7 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
       omClientResponse = new S3InitiateMultipartUploadResponse(
           createErrorOMResponse(omResponse, exception));
     } finally {
-      if (omClientResponse != null) {
-        omClientResponse.setFlushFuture(
-            ozoneManagerDoubleBufferHelper.add(omClientResponse,
-                transactionLogIndex));
-      }
+
 
 Review comment:
   Missed adding addResponseToDoubleBuffer() here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] hanishakoneru merged pull request #564: HDDS-3031. OM HA- Client requests get LeaderNotReadyException after OM's restart.

Posted by GitBox <gi...@apache.org>.
hanishakoneru merged pull request #564: HDDS-3031. OM HA- Client requests get LeaderNotReadyException after OM's restart.
URL: https://github.com/apache/hadoop-ozone/pull/564
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] hanishakoneru commented on issue #564: HDDS-3031. OM HA- Client requests get LeaderNotReadyException after OM's restart.

Posted by GitBox <gi...@apache.org>.
hanishakoneru commented on issue #564: HDDS-3031. OM HA- Client requests get LeaderNotReadyException after OM's restart.
URL: https://github.com/apache/hadoop-ozone/pull/564#issuecomment-589282066
 
 
   LGTM. +1.
   Thanks for fixing this. Will merge this PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org