You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Rodoni (Code Review)" <ge...@cloudera.org> on 2018/07/26 23:47:06 UTC
[Impala-ASF-CR] IMPALA-7195: [DOCS] Impala delegation with groups
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11068
Change subject: IMPALA-7195: [DOCS] Impala delegation with groups
......................................................................
IMPALA-7195: [DOCS] Impala delegation with groups
Change-Id: I6948ab2ef9b82b123f7a1f4fdc83cfb06e9f912f
---
M docs/topics/impala_delegation.xml
1 file changed, 135 insertions(+), 45 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/11068/1
--
To view, visit http://gerrit.cloudera.org:8080/11068
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6948ab2ef9b82b123f7a1f4fdc83cfb06e9f912f
Gerrit-Change-Number: 11068
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
[Impala-ASF-CR] IMPALA-7195 IMPALA-7222: [DOCS] Impala delegation with groups
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11068 )
Change subject: IMPALA-7195 IMPALA-7222: [DOCS] Impala delegation with groups
......................................................................
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/11068/2/docs/topics/impala_delegation.xml
File docs/topics/impala_delegation.xml:
http://gerrit.cloudera.org:8080/#/c/11068/2/docs/topics/impala_delegation.xml@77
PS2, Line 77: '<varname>user1</varname>=<varname>user2</varname>'
It maybe better to call this authenticated_user instead of user1 and also delegated_user instead of user2 to give more context.
http://gerrit.cloudera.org:8080/#/c/11068/2/docs/topics/impala_delegation.xml@123
PS2, Line 123: group1
This is wrong. The left-hand side is still a user. The client still sends the delegate user name. The server will perform an authorization to see if the delegate user belongs to the list of authorized delegated groups.
http://gerrit.cloudera.org:8080/#/c/11068/2/docs/topics/impala_delegation.xml@162
PS2, Line 162: The delegation process works as follows:
Please also explain the user delegation with --authorized_proxy_group_config. Also mention that --authorized_proxy_group_config does not supported ShellBasedUnixGroupsNetgroupMapping and ShellBasedUnixGroupsMapping Hadoop group mapping providers. The recommendation is to use the JNI-based mapping providers, such as JniBasedUnixGroupsMappingWithFallback and JniBasedUnixGroupsNetgroupMappingWithFallback. Reference: https://github.com/apache/impala/blob/master/fe/src/main/java/org/apache/impala/service/JniFrontend.java#L665-L680
--
To view, visit http://gerrit.cloudera.org:8080/11068
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6948ab2ef9b82b123f7a1f4fdc83cfb06e9f912f
Gerrit-Change-Number: 11068
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zsombor Fedor
Gerrit-Comment-Date: Fri, 27 Jul 2018 17:32:38 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7195 IMPALA-7222: [DOCS] Impala delegation with groups
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11068 )
Change subject: IMPALA-7195 IMPALA-7222: [DOCS] Impala delegation with groups
......................................................................
Patch Set 3:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/14/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/11068
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6948ab2ef9b82b123f7a1f4fdc83cfb06e9f912f
Gerrit-Change-Number: 11068
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zsombor Fedor
Gerrit-Comment-Date: Fri, 27 Jul 2018 21:00:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7195 IMPALA-7222: [DOCS] Impala delegation with groups
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11068 )
Change subject: IMPALA-7195 IMPALA-7222: [DOCS] Impala delegation with groups
......................................................................
Patch Set 3:
(10 comments)
http://gerrit.cloudera.org:8080/#/c/11068/3/docs/topics/impala_delegation.xml
File docs/topics/impala_delegation.xml:
http://gerrit.cloudera.org:8080/#/c/11068/3/docs/topics/impala_delegation.xml@67
PS3, Line 67: attention
Instead of having 2 attentions, wouldn't be it better to have one attention and maybe some bullet points?
http://gerrit.cloudera.org:8080/#/c/11068/3/docs/topics/impala_delegation.xml@75
PS3, Line 75:
Missing .
http://gerrit.cloudera.org:8080/#/c/11068/3/docs/topics/impala_delegation.xml@75
PS3, Line 75: User delegation is disabled
Use/group delegation is disabled. Reference: https://github.com/apache/impala/blob/b5608264b4552e44eb73ded1e232a8775c3dba6b/be/src/service/impala-server.cc#L1368-L1376
http://gerrit.cloudera.org:8080/#/c/11068/3/docs/topics/impala_delegation.xml@88
PS3, Line 88: authorized_user1
since we are using authenticated_user everywhere else in this doc, it's better to stay consistent and use authenticated_user
http://gerrit.cloudera.org:8080/#/c/11068/3/docs/topics/impala_delegation.xml@90
PS3, Line 90: authorized_user1
similarly with this
http://gerrit.cloudera.org:8080/#/c/11068/3/docs/topics/impala_delegation.xml@102
PS3, Line 102:
remove space
http://gerrit.cloudera.org:8080/#/c/11068/3/docs/topics/impala_delegation.xml@103
PS3, Line 103: , <codeph>,</codeph>,
too many , looking at the HTML output
http://gerrit.cloudera.org:8080/#/c/11068/3/docs/topics/impala_delegation.xml@107
PS3, Line 107:
remove space
http://gerrit.cloudera.org:8080/#/c/11068/3/docs/topics/impala_delegation.xml@108
PS3, Line 108: , <codeph>,</codeph>,
too many , looking at the HTML output
http://gerrit.cloudera.org:8080/#/c/11068/3/docs/topics/impala_delegation.xml@212
PS3, Line 212: is in
belongs to
--
To view, visit http://gerrit.cloudera.org:8080/11068
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6948ab2ef9b82b123f7a1f4fdc83cfb06e9f912f
Gerrit-Change-Number: 11068
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zsombor Fedor
Gerrit-Comment-Date: Mon, 30 Jul 2018 16:41:40 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7195 IMPALA-7222: [DOCS] Impala delegation with groups
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Fredy Wijaya, Zsombor Fedor, Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11068
to look at the new patch set (#3).
Change subject: IMPALA-7195 IMPALA-7222: [DOCS] Impala delegation with groups
......................................................................
IMPALA-7195 IMPALA-7222: [DOCS] Impala delegation with groups
Added clarifications about delegation.
Change-Id: I6948ab2ef9b82b123f7a1f4fdc83cfb06e9f912f
---
M docs/topics/impala_delegation.xml
1 file changed, 217 insertions(+), 45 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/11068/3
--
To view, visit http://gerrit.cloudera.org:8080/11068
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6948ab2ef9b82b123f7a1f4fdc83cfb06e9f912f
Gerrit-Change-Number: 11068
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zsombor Fedor
[Impala-ASF-CR] IMPALA-7195 IMPALA-7222: [DOCS] Impala delegation with groups
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11068 )
Change subject: IMPALA-7195 IMPALA-7222: [DOCS] Impala delegation with groups
......................................................................
Patch Set 2: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/13/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/11068
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6948ab2ef9b82b123f7a1f4fdc83cfb06e9f912f
Gerrit-Change-Number: 11068
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #406
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 27 Jul 2018 00:36:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7195 IMPALA-7222: [DOCS] Impala delegation with groups
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11068 )
Change subject: IMPALA-7195 IMPALA-7222: [DOCS] Impala delegation with groups
......................................................................
Patch Set 2:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/13/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/11068
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6948ab2ef9b82b123f7a1f4fdc83cfb06e9f912f
Gerrit-Change-Number: 11068
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 27 Jul 2018 00:27:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7195: [DOCS] Impala delegation with groups
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11068 )
Change subject: IMPALA-7195: [DOCS] Impala delegation with groups
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
I don't know enough about the technical side of this to verify the content, but the text seemed clear and I learned a little bit about a feature I knew very little about.
http://gerrit.cloudera.org:8080/#/c/11068/1/docs/topics/impala_delegation.xml
File docs/topics/impala_delegation.xml:
http://gerrit.cloudera.org:8080/#/c/11068/1/docs/topics/impala_delegation.xml@100
PS1, Line 100:
space intended?
--
To view, visit http://gerrit.cloudera.org:8080/11068
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6948ab2ef9b82b123f7a1f4fdc83cfb06e9f912f
Gerrit-Change-Number: 11068
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 27 Jul 2018 00:01:02 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7195 IMPALA-7222: [DOCS] Impala delegation with groups
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Fredy Wijaya, Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11068
to look at the new patch set (#2).
Change subject: IMPALA-7195 IMPALA-7222: [DOCS] Impala delegation with groups
......................................................................
IMPALA-7195 IMPALA-7222: [DOCS] Impala delegation with groups
Added clarifications about delegation.
Change-Id: I6948ab2ef9b82b123f7a1f4fdc83cfb06e9f912f
---
M docs/topics/impala_delegation.xml
1 file changed, 181 insertions(+), 45 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/11068/2
--
To view, visit http://gerrit.cloudera.org:8080/11068
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6948ab2ef9b82b123f7a1f4fdc83cfb06e9f912f
Gerrit-Change-Number: 11068
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-7195 IMPALA-7222: [DOCS] Impala delegation with groups
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11068 )
Change subject: IMPALA-7195 IMPALA-7222: [DOCS] Impala delegation with groups
......................................................................
Patch Set 4:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/21/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/11068
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6948ab2ef9b82b123f7a1f4fdc83cfb06e9f912f
Gerrit-Change-Number: 11068
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zsombor Fedor
Gerrit-Comment-Date: Mon, 30 Jul 2018 23:58:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7195: [DOCS] Impala delegation with groups
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11068 )
Change subject: IMPALA-7195: [DOCS] Impala delegation with groups
......................................................................
Patch Set 1:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/12/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/11068
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6948ab2ef9b82b123f7a1f4fdc83cfb06e9f912f
Gerrit-Change-Number: 11068
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 26 Jul 2018 23:47:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7195 IMPALA-7222: [DOCS] Impala delegation with groups
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Fredy Wijaya, Zsombor Fedor, Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11068
to look at the new patch set (#4).
Change subject: IMPALA-7195 IMPALA-7222: [DOCS] Impala delegation with groups
......................................................................
IMPALA-7195 IMPALA-7222: [DOCS] Impala delegation with groups
Added clarifications about delegation.
Change-Id: I6948ab2ef9b82b123f7a1f4fdc83cfb06e9f912f
---
M docs/topics/impala_delegation.xml
1 file changed, 222 insertions(+), 45 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/11068/4
--
To view, visit http://gerrit.cloudera.org:8080/11068
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6948ab2ef9b82b123f7a1f4fdc83cfb06e9f912f
Gerrit-Change-Number: 11068
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zsombor Fedor
[Impala-ASF-CR] IMPALA-7195 IMPALA-7222: [DOCS] Impala delegation with groups
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11068 )
Change subject: IMPALA-7195 IMPALA-7222: [DOCS] Impala delegation with groups
......................................................................
Patch Set 3:
(10 comments)
http://gerrit.cloudera.org:8080/#/c/11068/3/docs/topics/impala_delegation.xml
File docs/topics/impala_delegation.xml:
http://gerrit.cloudera.org:8080/#/c/11068/3/docs/topics/impala_delegation.xml@67
PS3, Line 67: attention
> Instead of having 2 attentions, wouldn't be it better to have one attention
Done
http://gerrit.cloudera.org:8080/#/c/11068/3/docs/topics/impala_delegation.xml@75
PS3, Line 75: User delegation is disabled
> Use/group delegation is disabled. Reference: https://github.com/apache/impa
Done
http://gerrit.cloudera.org:8080/#/c/11068/3/docs/topics/impala_delegation.xml@75
PS3, Line 75:
> Missing .
Done
http://gerrit.cloudera.org:8080/#/c/11068/3/docs/topics/impala_delegation.xml@88
PS3, Line 88: authorized_user1
> since we are using authenticated_user everywhere else in this doc, it's bet
Done
http://gerrit.cloudera.org:8080/#/c/11068/3/docs/topics/impala_delegation.xml@90
PS3, Line 90: authorized_user1
> similarly with this
Done
http://gerrit.cloudera.org:8080/#/c/11068/3/docs/topics/impala_delegation.xml@102
PS3, Line 102:
> remove space
Done
http://gerrit.cloudera.org:8080/#/c/11068/3/docs/topics/impala_delegation.xml@103
PS3, Line 103: , <codeph>,</codeph>,
> too many , looking at the HTML output
Done
http://gerrit.cloudera.org:8080/#/c/11068/3/docs/topics/impala_delegation.xml@107
PS3, Line 107:
> remove space
Done
http://gerrit.cloudera.org:8080/#/c/11068/3/docs/topics/impala_delegation.xml@108
PS3, Line 108: , <codeph>,</codeph>,
> too many , looking at the HTML output
Done
http://gerrit.cloudera.org:8080/#/c/11068/3/docs/topics/impala_delegation.xml@212
PS3, Line 212: is in
> belongs to
Done
--
To view, visit http://gerrit.cloudera.org:8080/11068
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6948ab2ef9b82b123f7a1f4fdc83cfb06e9f912f
Gerrit-Change-Number: 11068
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zsombor Fedor
Gerrit-Comment-Date: Mon, 30 Jul 2018 23:57:30 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7195 IMPALA-7222: [DOCS] Impala delegation with groups
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11068 )
Change subject: IMPALA-7195 IMPALA-7222: [DOCS] Impala delegation with groups
......................................................................
Patch Set 4: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/21/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/11068
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6948ab2ef9b82b123f7a1f4fdc83cfb06e9f912f
Gerrit-Change-Number: 11068
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zsombor Fedor
Gerrit-Comment-Date: Tue, 31 Jul 2018 00:24:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7195 IMPALA-7222: [DOCS] Impala delegation with groups
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11068 )
Change subject: IMPALA-7195 IMPALA-7222: [DOCS] Impala delegation with groups
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11068
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6948ab2ef9b82b123f7a1f4fdc83cfb06e9f912f
Gerrit-Change-Number: 11068
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zsombor Fedor
Gerrit-Comment-Date: Tue, 31 Jul 2018 15:53:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7195 IMPALA-7222: [DOCS] Impala delegation with groups
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11068 )
Change subject: IMPALA-7195 IMPALA-7222: [DOCS] Impala delegation with groups
......................................................................
IMPALA-7195 IMPALA-7222: [DOCS] Impala delegation with groups
Added clarifications about delegation.
Change-Id: I6948ab2ef9b82b123f7a1f4fdc83cfb06e9f912f
Reviewed-on: http://gerrit.cloudera.org:8080/11068
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Fredy Wijaya <fw...@cloudera.com>
---
M docs/topics/impala_delegation.xml
1 file changed, 222 insertions(+), 45 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Fredy Wijaya: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/11068
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6948ab2ef9b82b123f7a1f4fdc83cfb06e9f912f
Gerrit-Change-Number: 11068
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zsombor Fedor
[Impala-ASF-CR] IMPALA-7195 IMPALA-7222: [DOCS] Impala delegation with groups
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11068 )
Change subject: IMPALA-7195 IMPALA-7222: [DOCS] Impala delegation with groups
......................................................................
Patch Set 3: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/14/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/11068
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6948ab2ef9b82b123f7a1f4fdc83cfb06e9f912f
Gerrit-Change-Number: 11068
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zsombor Fedor
Gerrit-Comment-Date: Fri, 27 Jul 2018 21:15:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7195: [DOCS] Impala delegation with groups
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11068 )
Change subject: IMPALA-7195: [DOCS] Impala delegation with groups
......................................................................
Patch Set 1: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/12/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/11068
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6948ab2ef9b82b123f7a1f4fdc83cfb06e9f912f
Gerrit-Change-Number: 11068
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 26 Jul 2018 23:57:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7195 IMPALA-7222: [DOCS] Impala delegation with groups
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11068 )
Change subject: IMPALA-7195 IMPALA-7222: [DOCS] Impala delegation with groups
......................................................................
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/11068/2/docs/topics/impala_delegation.xml
File docs/topics/impala_delegation.xml:
http://gerrit.cloudera.org:8080/#/c/11068/2/docs/topics/impala_delegation.xml@77
PS2, Line 77: '<varname>user1</varname>=<varname>user2</varname>'
> It maybe better to call this authenticated_user instead of user1 and also d
Done
http://gerrit.cloudera.org:8080/#/c/11068/2/docs/topics/impala_delegation.xml@123
PS2, Line 123: group1
> This is wrong. The left-hand side is still a user. The client still sends t
Done
http://gerrit.cloudera.org:8080/#/c/11068/2/docs/topics/impala_delegation.xml@162
PS2, Line 162: The delegation process works as follows:
> Please also explain the user delegation with --authorized_proxy_group_confi
Done
--
To view, visit http://gerrit.cloudera.org:8080/11068
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6948ab2ef9b82b123f7a1f4fdc83cfb06e9f912f
Gerrit-Change-Number: 11068
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zsombor Fedor
Gerrit-Comment-Date: Fri, 27 Jul 2018 20:59:14 +0000
Gerrit-HasComments: Yes