You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/05/28 21:03:01 UTC
[GitHub] [cloudstack] shwstppr opened a new pull request #5050: ui: pass requireshvm param for register/upload template API
shwstppr opened a new pull request #5050:
URL: https://github.com/apache/cloudstack/pull/5050
### Description
HVM is set to true if `requireshvm` param of `registerTemplate` and `getUploadParamsForTemplate` APIs if not passed (null value).
This change explicitly passes `requireshvm=false` when the checkbox is unselected in the UI form.
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
Using UI
Without change (`requireshvm` is not passed):
In DB
```
MariaDB [cloud]> select id,name,uuid,hvm from vm_template where uuid='af94adf5-36c8-434d-a87f-5e8c6fdfd89a'\G
*************************** 1. row ***************************
id: 212
name: t31
uuid: af94adf5-36c8-434d-a87f-5e8c6fdfd89a
hvm: 1
```
With change:
In DB
```
MariaDB [cloud]> select id,name,uuid,hvm from vm_template where uuid='43b34bd5-d52a-47a5-928b-dc698bc4965c'\G
*************************** 1. row ***************************
id: 213
name: t41
uuid: 43b34bd5-d52a-47a5-928b-dc698bc4965c
hvm: 0
```
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5050: ui: pass requireshvm param for register/upload template API
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5050:
URL: https://github.com/apache/cloudstack/pull/5050#issuecomment-850676879
@shwstppr does this match the legacy UI behaviour?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5050: ui: pass requireshvm param for register/upload template API
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5050:
URL: https://github.com/apache/cloudstack/pull/5050#issuecomment-850668552
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #5050: ui: pass requireshvm param for register/upload template API
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #5050:
URL: https://github.com/apache/cloudstack/pull/5050
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5050: ui: pass requireshvm param for register/upload template API
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5050:
URL: https://github.com/apache/cloudstack/pull/5050#issuecomment-850670539
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5050 (SL-JID-181)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5050: ui: pass requireshvm param for register/upload template API
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5050:
URL: https://github.com/apache/cloudstack/pull/5050#issuecomment-850688379
@rhtyd legacy ui used to pass the parameter irrespective of its value. So, yes.
https://github.com/apache/cloudstack/blob/4.15.0.0/ui/legacy/scripts/templates.js#L631
Also, server sets the template as hvm when API param value is null,
https://github.com/apache/cloudstack/blob/4.15/server/src/main/java/com/cloud/template/TemplateAdapterBase.java#L171
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5050: ui: pass requireshvm param for register/upload template API
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5050:
URL: https://github.com/apache/cloudstack/pull/5050#issuecomment-850668746
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org