You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/08/26 12:43:18 UTC
[GitHub] [incubator-seatunnel] kalencaya opened a new pull request, #2543: [Bug][flink-connector-elasticsearch7]sink failure caused by deprecated TransportClient
kalencaya opened a new pull request, #2543:
URL: https://github.com/apache/incubator-seatunnel/pull/2543
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
fix #2539
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] kalencaya commented on a diff in pull request #2543: [Bug][flink-connector-elasticsearch7]sink failure caused by deprecated TransportClient
Posted by GitBox <gi...@apache.org>.
kalencaya commented on code in PR #2543:
URL: https://github.com/apache/incubator-seatunnel/pull/2543#discussion_r958043155
##########
seatunnel-connectors/seatunnel-connectors-flink/seatunnel-connector-flink-elasticsearch7/src/main/java/org/apache/seatunnel/flink/elasticsearch/sink/ElasticsearchOutputFormat.java:
##########
@@ -64,27 +62,14 @@ public ElasticsearchOutputFormat(Config userConfig, ElasticsearchSinkFunction<T>
@Override
public void configure(Configuration configuration) {
List<String> hosts = config.getStringList(HOSTS);
- Settings.Builder settings = Settings.builder();
-
- config.entrySet().forEach(entry -> {
Review Comment:
Elasticsearch will not support settings on rest client, neither 7.x RestHighLevelClient or 8.x ElasticsearchClient, for what all them based on RestClient doesn't support it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X commented on a diff in pull request #2543: [Bug][flink-connector-elasticsearch7]sink failure caused by deprecated TransportClient
Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on code in PR #2543:
URL: https://github.com/apache/incubator-seatunnel/pull/2543#discussion_r957400407
##########
seatunnel-connectors/seatunnel-connectors-flink/seatunnel-connector-flink-elasticsearch7/src/main/java/org/apache/seatunnel/flink/elasticsearch/sink/ElasticsearchOutputFormat.java:
##########
@@ -64,27 +62,14 @@ public ElasticsearchOutputFormat(Config userConfig, ElasticsearchSinkFunction<T>
@Override
public void configure(Configuration configuration) {
List<String> hosts = config.getStringList(HOSTS);
- Settings.Builder settings = Settings.builder();
-
- config.entrySet().forEach(entry -> {
Review Comment:
Seem like you remove custom setting for elasticsearch, please add it back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on pull request #2543: [Bug][flink-connector-elasticsearch7]sink failure caused by deprecated TransportClient
Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on PR #2543:
URL: https://github.com/apache/incubator-seatunnel/pull/2543#issuecomment-1277054491
Since this pr has not been updated for too long, I will close it. If necessary, please reopen it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 closed pull request #2543: [Bug][flink-connector-elasticsearch7]sink failure caused by deprecated TransportClient
Posted by GitBox <gi...@apache.org>.
EricJoy2048 closed pull request #2543: [Bug][flink-connector-elasticsearch7]sink failure caused by deprecated TransportClient
URL: https://github.com/apache/incubator-seatunnel/pull/2543
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X commented on pull request #2543: [Bug][flink-connector-elasticsearch7]sink failure caused by deprecated TransportClient
Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on PR #2543:
URL: https://github.com/apache/incubator-seatunnel/pull/2543#issuecomment-1236571574
Can you add connector e2e-testcase and update doc
reference：https://github.com/apache/incubator-seatunnel/pull/2499
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org