You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/10/26 07:28:37 UTC
[GitHub] [pulsar] lhotari opened a new pull request #8371: Improve protobuf and grpc dependency management
lhotari opened a new pull request #8371:
URL: https://github.com/apache/pulsar/pull/8371
### Motivation
For managing protobuf libraries there is a maven bom file available for protobuf. The benefit of using this is that it can be imported to the project's pom.xml dependency management to make sure that the versions of the various protobuf libraries are aligned and use the same version.
Besides starting to use protobuf-bom, it was noticed that there are separate settings for protobuf protoc version (`protoc3.version`) and the protoc grpc plugin versions (`protoc-gen-grpc-java.version`). These versions should match the protobuf and grpc versions. The PR also covers an improvement for that.
One motivation of this PR is to prepare for the grpc upgrade that was attempted by #8351 , but reverted. Before doing the grpc upgrade, it would be useful to improve the protobuf & grpc dependency management provided by this PR.
### Modifications
* Use protobuf-bom to manage protobuf library versions
* make `protoc3.version` match `protobuf3.version`
* there should be no reason that these would be different
* make grpc's `protoc-gen-grpc-java.version` match `grpc.version`
* there should be no reason that there would be different
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #8371: Improve protobuf and grpc dependency management
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #8371:
URL: https://github.com/apache/pulsar/pull/8371#issuecomment-717097619
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #8371: Improve protobuf and grpc dependency management
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #8371:
URL: https://github.com/apache/pulsar/pull/8371#issuecomment-716971093
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #8371: Improve protobuf and grpc dependency management
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #8371:
URL: https://github.com/apache/pulsar/pull/8371
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #8371: Improve protobuf and grpc dependency management
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #8371:
URL: https://github.com/apache/pulsar/pull/8371#issuecomment-716739486
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #8371: Improve protobuf and grpc dependency management
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #8371:
URL: https://github.com/apache/pulsar/pull/8371#issuecomment-716684647
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org