You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/01/08 18:38:35 UTC
[GitHub] andriisoldatenko commented on a change in pull request #4456:
[AIRFLOW-3645] Add base_executor_config
andriisoldatenko commented on a change in pull request #4456: [AIRFLOW-3645] Add base_executor_config
URL: https://github.com/apache/airflow/pull/4456#discussion_r246106528
##########
File path: airflow/models/__init__.py
##########
@@ -2563,6 +2568,25 @@ def pre_execute(self, context):
"""
pass
+ def get_executor_config(self, executor_config):
+ """Try to import base_executor_config and merge supplied
Review comment:
I think function docs MUST be in same format as in `def execute(self, context):`
e.g.
```
def get_executor_config(self, executor_config):
"""
Docs starts here
"""
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services