[jira] [Commented] (SUREFIRE-1306) JUnit4RerunFailingTestsIT does not execute with the JUnit version configured in the test

["Hudson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SUREFIRE-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15710390#comment-15710390 ] 

Hudson commented on SUREFIRE-1306:
----------------------------------

SUCCESS: Integrated in Jenkins build maven-surefire #1648 (See [https://builds.apache.org/job/maven-surefire/1648/])
SUREFIRE-1306: JUnit4RerunFailingTestsIT does not execute with the JUnit (tibor17: rev 15b953000afc26ca3844af7d18fd7b3c9ad26cd5)
* (edit) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/JUnit4RerunFailingTestsIT.java
* (edit) surefire-integration-tests/src/test/resources/junit4-rerun-failing-tests/pom.xml
[SUREFIRE-1306] JUnit4RerunFailingTestsIT does not execute with the (tibor17: rev 195e4833ca7abb0278d34bff94cd7669d5331e45)
* (edit) surefire-providers/common-junit4/src/main/java/org/apache/maven/surefire/common/junit4/JUnitTestFailureListener.java


> JUnit4RerunFailingTestsIT does not execute with the JUnit version configured in the test
> ----------------------------------------------------------------------------------------
>
>                 Key: SUREFIRE-1306
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1306
>             Project: Maven Surefire
>          Issue Type: Test
>            Reporter: Benedikt Ritter
>            Assignee: Tibor Digana
>             Fix For: 2.19.2
>
>
> All the test methods in JUnit4RerunFailingTestsIT set JUnit Version explicitly to 4.7 by calling {{setJUnitVersion( "4.7" )}}. This will in turn set the system property {{junit.version}}. The problem with this is, that the pom.xml in the test project (junit4-rerun-failing-tests) uses the property {{junitVersion}} instead. The version is set to 4.4 in pom.xml. Furthermore using JUnit 4.7 version in pom.xml results in test failures.
> Suggested solution: Drop the {{junitVersion}} property from pom.xml and use {{junit.version}} instead, making it possible to set the version from the test cases. Use version 4.12, since there seems to be a regression in 4.7 causing the test to fail with this version.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)