You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/10/24 07:00:30 UTC

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7404: romfs: expand file cache by CONFIG_FS_ROMFS_FCACHE_NSECTORS

pkarashchenko commented on code in PR #7404:
URL: https://github.com/apache/incubator-nuttx/pull/7404#discussion_r1002937958


##########
fs/romfs/Kconfig:
##########
@@ -20,4 +20,10 @@ config FS_ROMFS_CACHE_NODE
 		is mounted so that we can quick access entry of ROMFS
 		filesystem on emmc/sdcard.
 
+config FS_ROMFS_CACHE_FILE_NSECTORS
+	int "The number of file cache sector"
+	default 1

Review Comment:
   do we need to add range check here so 0 can't be set?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org