You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "pvillard31 (via GitHub)" <gi...@apache.org> on 2025/07/08 13:34:58 UTC

[PR] NIFI-14710 - Stateless should trigger failure callback when queues are not empty after process group is stopped [nifi]

pvillard31 opened a new pull request, #10074:
URL: https://github.com/apache/nifi/pull/10074

   # Summary
   
   [NIFI-14710](https://issues.apache.org/jira/browse/NIFI-14710) - Stateless should trigger failure callback when queues are not empty after process group is stopped
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
   
   ### Pull Request Tracking
   
   - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
   - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
   
   ### Pull Request Formatting
   
   - [ ] Pull Request based on current revision of the `main` branch
   - [ ] Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request creation.
   
   ### Build
   
   - [ ] Build completed using `mvn clean install -P contrib-check`
     - [ ] JDK 21
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] NIFI-14710 - Stateless should trigger failure callback when queues are not empty after process group is stopped [nifi]

Posted by "pvillard31 (via GitHub)" <gi...@apache.org>.
pvillard31 commented on PR #10074:
URL: https://github.com/apache/nifi/pull/10074#issuecomment-3052995988

   Thanks @markap14 - very good point! Pushed a commit to use `isDataQueuedForProcessing()` instead


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] NIFI-14710 - Stateless should trigger failure callback when queues are not empty after process group is stopped [nifi]

Posted by "sfc-gh-mpayne (via GitHub)" <gi...@apache.org>.
sfc-gh-mpayne commented on PR #10074:
URL: https://github.com/apache/nifi/pull/10074#issuecomment-3052942023

   Hey @pvillard31 thanks for jumping in here. I think this solution is close to what we need but not exactly. The issue is that checking `isFlowFileQueued()` will return `true` if any data is queued up at all, including queued up in the root group's Output Ports. When a stateless group is run, it will queue up the data in output ports until it's been acknowledged, and I don't think we want to count these connections here. So instead of `isFlowFileQueued()` I think we want to use `rootGroup.isDataQueuedForProcessing()`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] NIFI-14710 - Stateless should trigger failure callback when queues are not empty after process group is stopped [nifi]

Posted by "markap14 (via GitHub)" <gi...@apache.org>.
markap14 merged PR #10074:
URL: https://github.com/apache/nifi/pull/10074


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org