You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by "Sergei Nikulov (JIRA)" <ji...@apache.org> on 2014/09/30 09:27:36 UTC

[jira] [Created] (THRIFT-2745) C++ // Unit-test compilation fixes // pull request on github

Sergei Nikulov created THRIFT-2745:
--------------------------------------

             Summary: C++ // Unit-test compilation fixes // pull request on github
                 Key: THRIFT-2745
                 URL: https://issues.apache.org/jira/browse/THRIFT-2745
             Project: Thrift
          Issue Type: Bug
          Components: C++ - Library, Test Suite
    Affects Versions: 1.0
         Environment: Windows 7 (64bit)
Microsoft Visual Studio 2012
            Reporter: Sergei Nikulov
            Priority: Minor


Issue 1:
thrift\lib\cpp\test\concurrency\ThreadFactoryTests.h uses <unistd.h> for usleep().

Replaced usleep() with THRIFT_SLEEP_USEC() and removed inclusion of unistd.h

Issue 2:
static const double ERROR;
macro ERROR already defined in wingdi.h

Replaced with TEST_ERROR, but perhaps it is better to find it more better name.

PR: https://github.com/apache/thrift/pull/207





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)