You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by woggle <gi...@git.apache.org> on 2015/04/29 20:42:13 UTC
[GitHub] spark pull request: [SPARK-7214] Reserve space for unrolling even ...
GitHub user woggle opened a pull request:
https://github.com/apache/spark/pull/5784
[SPARK-7214] Reserve space for unrolling even when MemoryStore nearly full
If making the initial reservation of space to unrolling a block fails, attempt to drop blocks to make room before giving up.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/woggle/spark SPARK-7214
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/5784.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5784
----
commit d6002d8d8d39e068b4ae5ce9efe920e06b6f72ef
Author: Charles Reiss <wo...@apache.org>
Date: 2015-04-28T22:48:31Z
Test for unrolling when unrollMemoryThreshold is not available but would be if blocks are dropped.
commit 6c57a97fd0ea2a93ee797060fcb540d05b7dcdc1
Author: Charles Reiss <wo...@apache.org>
Date: 2015-04-29T05:37:32Z
Consistently call ensureFreeSpace() when reserving unroll memory.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7214] Reserve space for unrolling even ...
Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/5784#issuecomment-148848676
@woggle It turns out that my recent patch #9000 unintentionally fixed this issue :). In particular, reserving the initial memory now drops blocks (see [this line](https://github.com/apache/spark/blob/1ec0a0dc2819d3db3555799cb78c2946f652bff4/core/src/main/scala/org/apache/spark/storage/MemoryStore.scala#L273)). Can you verify?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7214] Reserve space for unrolling even ...
Posted by squito <gi...@git.apache.org>.
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/5784#issuecomment-97988730
I've been trying to come up with a scenario when this would be undesirable. I've only come up with one scenario: on the second put, you have less than the initial room available, AND the second block is bigger than your total memory. After this change, you'll end up with nothing in the cache, but before, you would still have the first block.
however, that is quite a stretch: you could end up in this situation before in any case, if you had more than the initial room available to start with, but the second block is bigger than your total memory.
does that seem right? not that this is a show stopper, just trying to make sure I understand
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7214] Reserve space for unrolling even ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5784#issuecomment-97540265
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7214] Reserve space for unrolling even ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5784#issuecomment-97538480
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7214] Reserve space for unrolling even ...
Posted by woggle <gi...@git.apache.org>.
Github user woggle commented on the pull request:
https://github.com/apache/spark/pull/5784#issuecomment-98004379
The idea about it happening anyways with slightly different amount of space is right; often fragmentation will mean that there will be more than unrollMemoryThreshold free in the MemoryStore even though it is essentially full.
Note that the total amount passed to ensureFreeSpace() is limited by maxUnrollMemory (taking into account already-reserved unrolling space), so, if there are no "huge" blocks, there's a limit to how much can be spuriously dropped.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7214] Reserve space for unrolling even ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5784#issuecomment-97538482
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31305/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7214] Reserve space for unrolling even ...
Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/5784#issuecomment-155562287
I think this patch is largely out of date by now given the new memory management patches. I would recommend we close this issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7214] Reserve space for unrolling even ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5784#issuecomment-97952605
[Test build #31441 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31441/consoleFull) for PR 5784 at commit [`16797ea`](https://github.com/apache/spark/commit/16797eab840787a7c7d507ccd7d6411779fec9a1).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
* This patch does not change any dependencies.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7214] Reserve space for unrolling even ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5784#issuecomment-97537522
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7214] Reserve space for unrolling even ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5784#issuecomment-97574723
[Test build #31308 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31308/consoleFull) for PR 5784 at commit [`16797ea`](https://github.com/apache/spark/commit/16797eab840787a7c7d507ccd7d6411779fec9a1).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `public final class UnsafeFixedWidthAggregationMap `
* ` public static class MapEntry `
* `public final class UnsafeRow implements MutableRow `
* `class UnsafeRowConverter(fieldTypes: Array[DataType]) `
* `case class Hypot(`
* `case class Pow(left: Expression, right: Expression) extends BinaryMathExpression(math.pow, "POWER")`
* `abstract class MathematicalExpression(f: Double => Double, name: String)`
* `case class Acos(child: Expression) extends MathematicalExpression(math.acos, "ACOS")`
* `case class Asin(child: Expression) extends MathematicalExpression(math.asin, "ASIN")`
* `case class Atan(child: Expression) extends MathematicalExpression(math.atan, "ATAN")`
* `case class Cbrt(child: Expression) extends MathematicalExpression(math.cbrt, "CBRT")`
* `case class Ceil(child: Expression) extends MathematicalExpression(math.ceil, "CEIL")`
* `case class Cos(child: Expression) extends MathematicalExpression(math.cos, "COS")`
* `case class Cosh(child: Expression) extends MathematicalExpression(math.cosh, "COSH")`
* `case class Exp(child: Expression) extends MathematicalExpression(math.exp, "EXP")`
* `case class Expm1(child: Expression) extends MathematicalExpression(math.expm1, "EXPM1")`
* `case class Floor(child: Expression) extends MathematicalExpression(math.floor, "FLOOR")`
* `case class Log(child: Expression) extends MathematicalExpression(math.log, "LOG")`
* `case class Log10(child: Expression) extends MathematicalExpression(math.log10, "LOG10")`
* `case class Log1p(child: Expression) extends MathematicalExpression(math.log1p, "LOG1P")`
* `case class Rint(child: Expression) extends MathematicalExpression(math.rint, "ROUND")`
* `case class Signum(child: Expression) extends MathematicalExpression(math.signum, "SIGNUM")`
* `case class Sin(child: Expression) extends MathematicalExpression(math.sin, "SIN")`
* `case class Sinh(child: Expression) extends MathematicalExpression(math.sinh, "SINH")`
* `case class Tan(child: Expression) extends MathematicalExpression(math.tan, "TAN")`
* `case class Tanh(child: Expression) extends MathematicalExpression(math.tanh, "TANH")`
* `case class Repartition(numPartitions: Int, shuffle: Boolean, child: LogicalPlan)`
* `case class RepartitionByExpression(partitionExpressions: Seq[Expression], child: LogicalPlan)`
* `case class Repartition(numPartitions: Int, shuffle: Boolean, child: SparkPlan)`
* `public final class PlatformDependent `
* `public class ByteArrayMethods `
* `public final class LongArray `
* `public final class BitSet `
* `public final class BitSetMethods `
* `public final class Murmur3_x86_32 `
* `public final class BytesToBytesMap `
* ` public final class Location `
* ` class Doubling implements HashMapGrowthStrategy `
* `public class ExecutorMemoryManager `
* `public class HeapMemoryAllocator implements MemoryAllocator `
* `public class MemoryBlock extends MemoryLocation `
* `public class MemoryLocation `
* `public final class TaskMemoryManager `
* `public class UnsafeMemoryAllocator implements MemoryAllocator `
* This patch **adds the following new dependencies:**
* `spark-unsafe_2.10-1.4.0-SNAPSHOT.jar`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7214] Reserve space for unrolling even ...
Posted by shaneknapp <gi...@git.apache.org>.
Github user shaneknapp commented on the pull request:
https://github.com/apache/spark/pull/5784#issuecomment-97894913
so, believe it or not, the jenkins bash environment is actually atomic (all machines are identical hardware, same kernel, system updates, package versions, ssh bash environment, etc). you can see the bash environment for the worker this job executed on here (https://amplab.cs.berkeley.edu/jenkins/computer/amp-jenkins-worker-08/log), and it's identical to all of the other ones.
regarding sha1, derp. i totally knew that. :p
anyways, i'll poke around those shell scripts some more and see if there's anything i can tweak to better report/fail on errors. i'm also going to redir a lot of the git error output to /dev/null as it's been cluttering up the test logs. i know there's a PR to move this stuff to python, but for the time being i'll see if i can't make things better. once the PR is done i'll add you (@brennonyork) as a reviewer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7214] Reserve space for unrolling even ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5784#issuecomment-97952631
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31441/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7214] Reserve space for unrolling even ...
Posted by shaneknapp <gi...@git.apache.org>.
Github user shaneknapp commented on the pull request:
https://github.com/apache/spark/pull/5784#issuecomment-97909684
jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7214] Reserve space for unrolling even ...
Posted by brennonyork <gi...@git.apache.org>.
Github user brennonyork commented on the pull request:
https://github.com/apache/spark/pull/5784#issuecomment-97845313
@shaneknapp well, to start, I couldn't agree more that something looks very fishy with `pr_public_classes`. That was a direct port from the previous code though which makes it even more interesting :/
To address the SHA1 hash its getting pulled from, as I'm sure you know, [this code here](https://github.com/jenkinsci/ghprb-plugin/blob/master/src/main/java/org/jenkinsci/plugins/ghprb/GhprbTrigger.java#L170) which, I'll admit, is interesting in and of itself in that it could produce the SHA1 as an actual hash **or** what we see above (in the case that the patch can merge without conflict into master).
That said `pr_public_classes` only relies on the `ghprbActualCommit` and not the SHA1 so unless that were empty somehow I'm not immediately sure how this could be happening (of which it isn't empty according to Jenkins).
My only thought, and I'm hoping you could shed some light here, would be a possible race condition from some shared state on each Jenkins box such that the Bash calls (or environment variables) aren't atomic to the PR they're building. Thoughts on that? I'll continue to dig and see what I can find.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7214] Reserve space for unrolling even ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5784#issuecomment-97574737
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31308/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7214] Reserve space for unrolling even ...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/5784#issuecomment-148824237
Hey @andrewor14, given our recent discussions / work on unrolling, do you think this PR is still necessary / relevant?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7214] Reserve space for unrolling even ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5784#issuecomment-97911230
[Test build #31441 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31441/consoleFull) for PR 5784 at commit [`16797ea`](https://github.com/apache/spark/commit/16797eab840787a7c7d507ccd7d6411779fec9a1).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7214] Reserve space for unrolling even ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5784#issuecomment-97910717
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7214] Reserve space for unrolling even ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5784#issuecomment-97538473
[Test build #31305 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31305/consoleFull) for PR 5784 at commit [`6c57a97`](https://github.com/apache/spark/commit/6c57a97fd0ea2a93ee797060fcb540d05b7dcdc1).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
* This patch does not change any dependencies.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7214] Reserve space for unrolling even ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5784#issuecomment-97540375
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7214] Reserve space for unrolling even ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5784#issuecomment-97537862
[Test build #31305 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31305/consoleFull) for PR 5784 at commit [`6c57a97`](https://github.com/apache/spark/commit/6c57a97fd0ea2a93ee797060fcb540d05b7dcdc1).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7214] Reserve space for unrolling even ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5784#issuecomment-97540569
[Test build #31308 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31308/consoleFull) for PR 5784 at commit [`16797ea`](https://github.com/apache/spark/commit/16797eab840787a7c7d507ccd7d6411779fec9a1).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7214] Reserve space for unrolling even ...
Posted by woggle <gi...@git.apache.org>.
Github user woggle commented on the pull request:
https://github.com/apache/spark/pull/5784#issuecomment-155571315
Agreed. I haven't had a chance to actually make sure your ptach #9000 it fixes the problem, but it looks like it should.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7214] Reserve space for unrolling even ...
Posted by woggle <gi...@git.apache.org>.
Github user woggle closed the pull request at:
https://github.com/apache/spark/pull/5784
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7214] Reserve space for unrolling even ...
Posted by brennonyork <gi...@git.apache.org>.
Github user brennonyork commented on the pull request:
https://github.com/apache/spark/pull/5784#issuecomment-97910902
thanks for that clarity @shaneknapp. Looks like I don't have access to see the Jenkins environment variables from the link you sent (unless it became stale before I clicked), but I'll look for the review note and provide what I can!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7214] Reserve space for unrolling even ...
Posted by squito <gi...@git.apache.org>.
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/5784#discussion_r29476383
--- Diff: core/src/main/scala/org/apache/spark/storage/MemoryStore.scala ---
@@ -280,20 +283,10 @@ private[spark] class MemoryStore(blockManager: BlockManager, maxMemory: Long)
val currentSize = vector.estimateSize()
if (currentSize >= memoryThreshold) {
val amountToRequest = (currentSize * memoryGrowthFactor - memoryThreshold).toLong
- // Hold the accounting lock, in case another thread concurrently puts a block that
- // takes up the unrolling space we just ensured here
--- End diff --
move this comment into the new method
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7214] Reserve space for unrolling even ...
Posted by shaneknapp <gi...@git.apache.org>.
Github user shaneknapp commented on the pull request:
https://github.com/apache/spark/pull/5784#issuecomment-97610281
@brennonyork -- something seems strange w/the output of pr_public_classes.sh...
i checked the jenkins output also, and it's reporting that the SHA1 is "SHA1: origin/pr/5784/merge", which seems not right. thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7214] Reserve space for unrolling even ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5784#issuecomment-97574735
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7214] Reserve space for unrolling even ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5784#issuecomment-98004472
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7214] Reserve space for unrolling even ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5784#issuecomment-97910659
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7214] Reserve space for unrolling even ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5784#issuecomment-97952629
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7214] Reserve space for unrolling even ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5784#issuecomment-97537507
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7214] Reserve space for unrolling even ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5784#issuecomment-98004666
[Test build #31481 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31481/consoleFull) for PR 5784 at commit [`fa212c1`](https://github.com/apache/spark/commit/fa212c10a43ffe99b8a270a991fea32ab10caf2a).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7214] Reserve space for unrolling even ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5784#issuecomment-98004461
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org