[GitHub] yiguolei commented on a change in pull request #628: Fix bug in rollback txn case

[GitBox <gi...@apache.org>]

yiguolei commented on a change in pull request #628: Fix bug in rollback txn case
URL: https://github.com/apache/incubator-doris/pull/628#discussion_r256670593
 
 

 ##########
 File path: be/src/olap/txn_manager.cpp
 ##########
 @@ -263,6 +266,10 @@ OLAPStatus TxnManager::publish_txn(OlapMeta* meta, TPartitionId partition_id, TT
     }
 }
 
+// txn could be rollbacked if it does not have related rowset
+// if the txn has related rowset then could not rollback it, because it 
+// may be committed in another thread and our current thread meets erros when writing to data file
+// be has to wait for fe call clear txn api
 
 Review comment:
   In stream load scenario, if coordinator be send two ingest commands, there maybe two running thread to load the rowset.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org