[GitHub] [superset] RahulRaj97 commented on a diff in pull request #19319: feat: catalogs functionality (presto)

[GitBox <gi...@apache.org>]

RahulRaj97 commented on code in PR #19319:
URL: https://github.com/apache/superset/pull/19319#discussion_r841283970


##########
superset-frontend/src/components/TableSelector/index.tsx:
##########
@@ -174,56 +185,73 @@ const TableSelector: FunctionComponent<TableSelectorProps> = ({
     // reset selections
     if (database === undefined) {
       setCurrentDatabase(undefined);
+      setCurrentCatalog(undefined);
       setCurrentSchema(undefined);
       setCurrentTable(undefined);
     }
   }, [database]);
 
   useEffect(() => {
-    if (currentDatabase && currentSchema) {
+    if (shouldLoadTables(currentDatabase)) {
       setLoadingTables(true);
-      const encodedSchema = encodeURIComponent(currentSchema);
       const forceRefresh = refresh !== previousRefresh;
-      // TODO: Would be nice to add pagination in a follow-up. Needs endpoint changes.

Review Comment:
   Moved to `getEndpoint` callback



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org