You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by so...@apache.org on 2022/04/18 10:18:14 UTC

[dolphinscheduler] branch dev updated: [Perf][UI Next][V1.0.0-Beta] Optimize judgment logic. (#9561)

This is an automated email from the ASF dual-hosted git repository.

songjian pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/dolphinscheduler.git


The following commit(s) were added to refs/heads/dev by this push:
     new e534ca1298 [Perf][UI Next][V1.0.0-Beta] Optimize judgment logic. (#9561)
e534ca1298 is described below

commit e534ca1298d1910c3f66d000cf6e6aab39086811
Author: songjianet <17...@qq.com>
AuthorDate: Mon Apr 18 18:18:07 2022 +0800

    [Perf][UI Next][V1.0.0-Beta] Optimize judgment logic. (#9561)
---
 .../src/views/projects/task/components/node/detail-modal.tsx      | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/dolphinscheduler-ui-next/src/views/projects/task/components/node/detail-modal.tsx b/dolphinscheduler-ui-next/src/views/projects/task/components/node/detail-modal.tsx
index 257fc4ea01..875f85e467 100644
--- a/dolphinscheduler-ui-next/src/views/projects/task/components/node/detail-modal.tsx
+++ b/dolphinscheduler-ui-next/src/views/projects/task/components/node/detail-modal.tsx
@@ -118,9 +118,7 @@ const NodeDetailModal = defineComponent({
         {
           text: t('project.node.instructions'),
           show:
-            taskType && !TASK_TYPES_MAP[taskType]?.helperLinkDisable
-              ? true
-              : false,
+            !!(taskType && !TASK_TYPES_MAP[taskType]?.helperLinkDisable),
           action: () => {
             const helpUrl =
               'https://dolphinscheduler.apache.org/' +
@@ -134,7 +132,7 @@ const NodeDetailModal = defineComponent({
         },
         {
           text: t('project.node.view_history'),
-          show: props.taskInstance ? true : false,
+          show: !!props.taskInstance,
           action: () => {
             router.push({
               name: 'task-instance',
@@ -145,7 +143,7 @@ const NodeDetailModal = defineComponent({
         },
         {
           text: t('project.node.view_log'),
-          show: props.taskInstance ? true : false,
+          show: !!props.taskInstance,
           action: () => {
             handleViewLog()
           },