You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2019/09/12 23:23:48 UTC

[GitHub] [helix] alirezazamani opened a new pull request #472: Change the way Helix triggers rebalance

alirezazamani opened a new pull request #472: Change the way Helix triggers rebalance
URL: https://github.com/apache/helix/pull/472
 
 
   ### Issues
   - [x] My PR addresses the following Helix issues and references them in the PR title:
   Issue #327 
   
   ### Description
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   A method is added which instantly generates OnDemandRebalance event.
   This event cause the controller to run rebalance for both of the pipelines.
   Previous touch logics has have been removed and replaced by new method.
   Tests have been changed accordingly (Resolved TODO have been removed).
   
   ### Tests
   
   mvn test have been run several times.
   
   - [x] The following is the result of the "mvn test" command on the appropriate module:
   
   Test Result 1: mvn test
   [ERROR] Tests run: 851, Failures: 3, Errors: 0, Skipped: 0, Time elapsed: 3,231.537 s <<< FAILURE! - in TestSuite
   [ERROR] testTaskPerformanceMetrics(org.apache.helix.monitoring.mbeans.TestTaskPerformanceMetrics)  Time elapsed: 2.215 s  <<< FAILURE!
   java.lang.AssertionError: expected:<true> but was:<false>
   	at org.apache.helix.monitoring.mbeans.TestTaskPerformanceMetrics.testTaskPerformanceMetrics(TestTaskPerformanceMetrics.java:118)
   
   [ERROR] testLostZkConnection(org.apache.helix.integration.TestZkConnectionLost)  Time elapsed: 83.743 s  <<< FAILURE!
   org.apache.helix.HelixException: Workflow "testLostZkConnection_20190912T223749" context is empty or not in states: "[COMPLETED]", current state: "IN_PROGRESS"
   	at org.apache.helix.integration.TestZkConnectionLost.testLostZkConnection(TestZkConnectionLost.java:140)
   
   [ERROR] testForceDeleteJobFromJobQueue(org.apache.helix.integration.task.TestDeleteJobFromJobQueue)  Time elapsed: 0.256 s  <<< FAILURE!
   org.apache.helix.HelixException: Failed to delete job: testForceDeleteJobFromJobQueue_job2 from queue: testForceDeleteJobFromJobQueue
   	at org.apache.helix.integration.task.TestDeleteJobFromJobQueue.testForceDeleteJobFromJobQueue(TestDeleteJobFromJobQueue.java:75)
   
   [INFO] 
   [INFO] Results:
   [INFO] 
   [ERROR] Failures: 
   [ERROR]   TestZkConnectionLost.testLostZkConnection:140 » Helix Workflow "testLostZkConn...
   [ERROR]   TestDeleteJobFromJobQueue.testForceDeleteJobFromJobQueue:75 » Helix Failed to ...
   [ERROR]   TestTaskPerformanceMetrics.testTaskPerformanceMetrics:118 expected:<true> but was:<false>
   [INFO] 
   [ERROR] Tests run: 851, Failures: 3, Errors: 0, Skipped: 0
   [INFO] 
   [INFO] ------------------------------------------------------------------------
   [INFO] BUILD FAILURE
   [INFO] ------------------------------------------------------------------------
   [INFO] Total time:  53:55 min
   [INFO] Finished at: 2019-09-12T16:13:48-07:00
   [INFO] ------------------------------------------------------------------------
   [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M3:test (default-test) on project helix-core: There are test failures.
   [ERROR] 
   [ERROR] Please refer to /home/anajari/my_repos/helix/helix-core/target/surefire-reports for the individual test results.
   [ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
   [ERROR] -> [Help 1]
   [ERROR] 
   [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
   [ERROR] Re-run Maven using the -X switch to enable full debug logging.
   [ERROR] 
   [ERROR] For more information about the errors and possible solutions, please read the following articles:
   [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
   
   
   
   
   Test Result 2: mvn test -Dtest="TestZkConnectionLost,TestDeleteJobFromJobQueue,TestTaskPerformanceMetrics"
   [INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 53.755 s - in TestSuite
   [INFO] 
   [INFO] Results:
   [INFO] 
   [INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0
   [INFO] 
   [INFO] ------------------------------------------------------------------------
   [INFO] BUILD SUCCESS
   [INFO] ------------------------------------------------------------------------
   [INFO] Total time:  58.522 s
   [INFO] Finished at: 2019-09-12T16:16:36-07:00
   [INFO] ------------------------------------------------------------------------
   
   
   ### Commits
   
   - [x] My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Code Quality
   
   - [x] My diff has been formatted using helix-style.xml

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org