[GitHub] [nifi] mark-bathori commented on a diff in pull request #7268: NIFI-11552: Support FlowFile Attributes in some PutIceberg properties

["mark-bathori (via GitHub)" <gi...@apache.org>]

mark-bathori commented on code in PR #7268:
URL: https://github.com/apache/nifi/pull/7268#discussion_r1200624778


##########
nifi-nar-bundles/nifi-iceberg-bundle/nifi-iceberg-processors/src/main/java/org/apache/nifi/processors/iceberg/PutIceberg.java:
##########
@@ -91,14 +92,16 @@ public class PutIceberg extends AbstractIcebergProcessor {
             .name("catalog-namespace")
             .displayName("Catalog Namespace")
             .description("The namespace of the catalog.")
+            .expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
             .required(true)
             .addValidator(StandardValidators.NON_BLANK_VALIDATOR)
             .build();
 
     static final PropertyDescriptor TABLE_NAME = new PropertyDescriptor.Builder()
             .name("table-name")
             .displayName("Table Name")
-            .description("The name of the table.")
+            .description("The name of the Iceberg table name to write to.")

Review Comment:
   There is a typo, the "name" word is not needed twice.



##########
nifi-nar-bundles/nifi-iceberg-bundle/nifi-iceberg-processors/src/test/java/org/apache/nifi/processors/iceberg/TestPutIcebergWithHiveCatalog.java:
##########
@@ -256,10 +256,13 @@ public void onTriggerUnPartitioned(String fileFormat) throws Exception {
         runner = TestRunners.newTestRunner(processor);
         initRecordReader();
         initCatalog(PartitionSpec.unpartitioned(), fileFormat);
-        runner.setProperty(PutIceberg.CATALOG_NAMESPACE, CATALOG_NAME);
-        runner.setProperty(PutIceberg.TABLE_NAME, TABLE_NAME);
+        runner.setProperty(PutIceberg.CATALOG_NAMESPACE, "${catalog.name}");
+        runner.setProperty(PutIceberg.TABLE_NAME, "${table.name}");

Review Comment:
   Could you add the `maximumFileSize` property to the test, it also got support for `FLOWFILE_ATTRIBUTES` so would be nice to cover that too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org