You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "zhongqiangczq (via GitHub)" <gi...@apache.org> on 2023/01/30 10:25:22 UTC
[GitHub] [incubator-celeborn] zhongqiangczq opened a new pull request, #1184: [CELEBORN-243] fix bug that os's disk usage is low but celeborn think…
zhongqiangczq opened a new pull request, #1184:
URL: https://github.com/apache/incubator-celeborn/pull/1184
…s that it's high_disk_usage
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
StorageManager.workingDirWriters doesn't cleanup expired filewriter, so that it will exceed disk capacity by summing all the history filelength.
In woker's log , we will see the error log as follows:
### Why are the changes needed?
WARN [device-check-thread-36004] DeviceMonitor: /mnt/disk1 usage is above threshold. Disk usage(Report by OS):{total:1759 GB, free:1647 GB, used_percent:2%} usage(Report by Celeborn):{total:1669.4 GB free:-16921305251.0 B }
ERROR [worker-disk-checker] LocalDeviceMonitor: /mnt/disk1 high_disk_usage error, notify observers
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
@RexXiong @waitinfuture @FMX
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1184: [CELEBORN-243] fix bug that os's disk usage is low but celeborn think…
Posted by codecov.
codecov[bot] commented on PR #1184:
URL: https://github.com/apache/incubator-celeborn/pull/1184#issuecomment-1410509952
# [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1184?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1184](https://codecov.io/gh/apache/incubator-celeborn/pull/1184?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d5dc5b7) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/da061b6c82ed05e3d01559921f58c6831a102bf3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (da061b6) will **decrease** coverage by `0.00%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## main #1184 +/- ##
============================================
- Coverage 26.89% 26.88% -0.00%
Complexity 776 776
============================================
Files 205 205
Lines 17399 17405 +6
Branches 1895 1895
============================================
Hits 4678 4678
- Misses 12401 12407 +6
Partials 320 320
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-celeborn/pull/1184?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/celeborn/service/deploy/worker/Worker.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1184?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d29ya2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vc2VydmljZS9kZXBsb3kvd29ya2VyL1dvcmtlci5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture commented on a diff in pull request #1184: [CELEBORN-243] fix bug that os's disk usage is low but celeborn think…
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture commented on code in PR #1184:
URL: https://github.com/apache/incubator-celeborn/pull/1184#discussion_r1091643836
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/Worker.scala:
##########
@@ -422,6 +422,13 @@ private[celeborn] class Worker(
fileWriter.destroy(new IOException(
s"Destroy FileWriter ${fileWriter} caused by shuffle ${shuffleKey} expired."))
}
+ val expiredFileWrites =
+ partitionLocationInfo.getAllMasterLocations(shuffleKey).asScala.map(p =>
Review Comment:
We can delete the fileWriter when traverse the locations in the upper code block. mountPoint can be reconstructed from fileWriter.FileInfo.filePath, which is always ```${mountPoint}/${appId}/${shuffleId}/${fileName}```
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/StorageManager.scala:
##########
@@ -420,6 +420,15 @@ final private[worker] class StorageManager(conf: CelebornConf, workerSource: Abs
}.toSeq.sortBy(_._2).reverse.take(conf.metricsAppTopDiskUsageCount * 2).toMap.asJava
}
+ def cleanupExpiredFileWriter(expiredFileWriters: Seq[FileWriter]): Unit = {
Review Comment:
we can delete this method
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/Worker.scala:
##########
@@ -47,7 +47,7 @@ import org.apache.celeborn.common.quota.ResourceConsumption
import org.apache.celeborn.common.rpc._
import org.apache.celeborn.common.util.{ShutdownHookManager, ThreadUtils, Utils}
import org.apache.celeborn.server.common.{HttpService, Service}
-import org.apache.celeborn.service.deploy.worker.storage.{PartitionFilesSorter, StorageManager}
+import org.apache.celeborn.service.deploy.worker.storage.{FileWriter, PartitionFilesSorter, StorageManager}
Review Comment:
unused import of FileWriter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] AngersZhuuuu merged pull request #1184: [CELEBORN-243] fix bug that os's disk usage is low but celeborn thinks that it's high_disk_usage
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu merged PR #1184:
URL: https://github.com/apache/incubator-celeborn/pull/1184
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] zhongqiangczq commented on a diff in pull request #1184: [CELEBORN-243] fix bug that os's disk usage is low but celeborn think…
Posted by "zhongqiangczq (via GitHub)" <gi...@apache.org>.
zhongqiangczq commented on code in PR #1184:
URL: https://github.com/apache/incubator-celeborn/pull/1184#discussion_r1092658646
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/StorageManager.scala:
##########
@@ -420,6 +420,15 @@ final private[worker] class StorageManager(conf: CelebornConf, workerSource: Abs
}.toSeq.sortBy(_._2).reverse.take(conf.metricsAppTopDiskUsageCount * 2).toMap.asJava
}
+ def cleanupExpiredFileWriter(expiredFileWriters: Seq[FileWriter]): Unit = {
Review Comment:
ok, it's deleted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] zhongqiangczq commented on a diff in pull request #1184: [CELEBORN-243] fix bug that os's disk usage is low but celeborn think…
Posted by "zhongqiangczq (via GitHub)" <gi...@apache.org>.
zhongqiangczq commented on code in PR #1184:
URL: https://github.com/apache/incubator-celeborn/pull/1184#discussion_r1092657526
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/Worker.scala:
##########
@@ -47,7 +47,7 @@ import org.apache.celeborn.common.quota.ResourceConsumption
import org.apache.celeborn.common.rpc._
import org.apache.celeborn.common.util.{ShutdownHookManager, ThreadUtils, Utils}
import org.apache.celeborn.server.common.{HttpService, Service}
-import org.apache.celeborn.service.deploy.worker.storage.{PartitionFilesSorter, StorageManager}
+import org.apache.celeborn.service.deploy.worker.storage.{FileWriter, PartitionFilesSorter, StorageManager}
Review Comment:
now it's used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] zhongqiangczq commented on a diff in pull request #1184: [CELEBORN-243] fix bug that os's disk usage is low but celeborn think…
Posted by "zhongqiangczq (via GitHub)" <gi...@apache.org>.
zhongqiangczq commented on code in PR #1184:
URL: https://github.com/apache/incubator-celeborn/pull/1184#discussion_r1092660074
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/Worker.scala:
##########
@@ -422,6 +422,13 @@ private[celeborn] class Worker(
fileWriter.destroy(new IOException(
s"Destroy FileWriter ${fileWriter} caused by shuffle ${shuffleKey} expired."))
}
+ val expiredFileWrites =
+ partitionLocationInfo.getAllMasterLocations(shuffleKey).asScala.map(p =>
Review Comment:
now filewriter is delete in locations traverse code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org