You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2023/01/18 16:28:51 UTC
[GitHub] [iceberg] amogh-jahagirdar opened a new pull request, #6618: API: Rename query to sql on SQLViewRepresentation API
amogh-jahagirdar opened a new pull request, #6618:
URL: https://github.com/apache/iceberg/pull/6618
The spec defines "sql" as the field in SQL view representation but at the API level it's called query. Renaming the API for consistency purposes and as discussed on https://github.com/apache/iceberg/pull/6612 concluded that sql is the best field name (rather than updating the spec to use query) since this will always be a SQL string and not some generic query string for SQL view representation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on pull request #6618: API: Rename query to sql on SQLViewRepresentation API
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on PR #6618:
URL: https://github.com/apache/iceberg/pull/6618#issuecomment-1396138663
Thanks for fixing this @amogh-jahagirdar , and thanks for everyone's review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 merged pull request #6618: API: Rename query to sql on SQLViewRepresentation API
Posted by GitBox <gi...@apache.org>.
jackye1995 merged PR #6618:
URL: https://github.com/apache/iceberg/pull/6618
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org