[GitHub] marcoabreu commented on a change in pull request #13544: turn on Sphinx warnings as errors

[GitBox <gi...@apache.org>]

marcoabreu commented on a change in pull request #13544: turn on Sphinx warnings as errors
URL: https://github.com/apache/incubator-mxnet/pull/13544#discussion_r239313917
 
 

 ##########
 File path: docs/build_version_doc/build_all_version.sh
 ##########
 @@ -117,6 +120,8 @@ function checkout () {
   git checkout "$repo_folder" || git branch $repo_folder "upstream/$repo_folder" && git checkout "$repo_folder" || exit 1
   if [ $tag == 'master' ]; then
     git pull
+    # master gets warnings as errors for Sphinx builds
 
 Review comment:
   Shouldn't we enable this in general? Otherwise a release branch might run into problems.
   
   Also, is this script executed as part of the pr pipeline? We want to fail PRs ideally

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services