[jira] [Commented] (AIRFLOW-1242) BigQueryHook assumes that a valid project_id can't contain a ':'

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-1242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16041380#comment-16041380 ] 

ASF subversion and git services commented on AIRFLOW-1242:
----------------------------------------------------------

Commit ffe6162f2b9e61f686b1fe993eb95e43e60c7dd5 in incubator-airflow's branch refs/heads/master from [~zoy@google.com]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=ffe6162 ]

[AIRFLOW-1242] Allowing project_id to have a colon in it.

Closes #2335 from zoyahav/master


> BigQueryHook assumes that a valid project_id can't contain a ':'
> ----------------------------------------------------------------
>
>                 Key: AIRFLOW-1242
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-1242
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: gcp
>            Reporter: Zohar Yahav
>            Assignee: Zohar Yahav
>            Priority: Minor
>
> BigQueryHook's _split_tablename method assumes that a project_id that contains a colon is invalid, although projects can be named "<domain>:<project>".
> This means that such projects would have to rely on the default project_id being set, instead of passing in "project_id:dataset.table"/"project_id.dataset.table".
> Code reference:
> https://github.com/apache/incubator-airflow/blob/master/airflow/contrib/hooks/bigquery_hook.py#L928



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)