You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2021/02/24 12:27:00 UTC

[GitHub] [tinkerpop] spmallette opened a new pull request #1398: TINKERPOP-2517 Added a TemporaryException and ResponseStatusCode

spmallette opened a new pull request #1398:
URL: https://github.com/apache/tinkerpop/pull/1398


   https://issues.apache.org/jira/browse/TINKERPOP-2517
   
   Implemented `TemporaryException` as an interface which means we can't really try-catch it but this approach is probably easier for providers who already have existing exception hierarchies and would just like to be able to hook into Gremlin Server's `TemporaryException` to `ResponseStatusCode.SERVER_ERROR_TEMPORARY` mapping and to not introduce breaks into embedded mode implementations where certain hierarchies are already expected.
   
   Targeted `master` rather than `3.4-dev` as I have some concerns about serialization of enums and compatibility there. Also, this feels like a new enough piece of functionality (though a simple implementation in TinkerPop) that it should come with a minor upgrade. 
   
   All tests pass with `docker/build.sh -t -n -i`
   
   VOTE +1


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tinkerpop] spmallette merged pull request #1398: TINKERPOP-2517 Added a TemporaryException and ResponseStatusCode

Posted by GitBox <gi...@apache.org>.
spmallette merged pull request #1398:
URL: https://github.com/apache/tinkerpop/pull/1398


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org