You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "timeabarna (via GitHub)" <gi...@apache.org> on 2023/10/04 07:23:03 UTC
[PR] NIFI-12166 Add repo usage to the monitoring endpoint [nifi]
timeabarna opened a new pull request, #7836:
URL: https://github.com/apache/nifi/pull/7836
# Summary
[NIFI-12166](https://issues.apache.org/jira/browse/NIFI-12166)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [ ] Pull Request based on current revision of the `main` branch
- [ ] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `mvn clean install -P contrib-check`
- [ ] JDK 21
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-12166 Add repo usage to the monitoring endpoint [nifi]
Posted by "timeabarna (via GitHub)" <gi...@apache.org>.
timeabarna commented on code in PR #7836:
URL: https://github.com/apache/nifi/pull/7836#discussion_r1347115429
##########
nifi-nar-bundles/nifi-extension-utils/nifi-prometheus-utils/pom.xml:
##########
@@ -53,6 +53,11 @@
<artifactId>nifi-metrics</artifactId>
<version>2.0.0-SNAPSHOT</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-framework-api</artifactId>
+ <version>2.0.0-SNAPSHOT</version>
+ </dependency>
Review Comment:
Thanks @markap14 for your review. I've modified the code based on your recommendations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-12166 Add repo usage to the monitoring endpoint [nifi]
Posted by "markap14 (via GitHub)" <gi...@apache.org>.
markap14 merged PR #7836:
URL: https://github.com/apache/nifi/pull/7836
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-12166 Add repo usage to the monitoring endpoint [nifi]
Posted by "markap14 (via GitHub)" <gi...@apache.org>.
markap14 commented on code in PR #7836:
URL: https://github.com/apache/nifi/pull/7836#discussion_r1345916108
##########
nifi-nar-bundles/nifi-extension-utils/nifi-prometheus-utils/pom.xml:
##########
@@ -53,6 +53,11 @@
<artifactId>nifi-metrics</artifactId>
<version>2.0.0-SNAPSHOT</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-framework-api</artifactId>
+ <version>2.0.0-SNAPSHOT</version>
+ </dependency>
Review Comment:
We should not have extensions / utils depending on nifi-framework-api. That is solely for use by the nifi framework and can change at any point in time.
I would be okay with moving the `StorageUsage` class to nifi-api and adding methods to `EventAccess` to expose the `StorageUsage` for the particular repositories, but we should not be exposing things like SystemDiagnostics to extensions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-12166 Add repo usage to the monitoring endpoint [nifi]
Posted by "timeabarna (via GitHub)" <gi...@apache.org>.
timeabarna commented on code in PR #7836:
URL: https://github.com/apache/nifi/pull/7836#discussion_r1347115429
##########
nifi-nar-bundles/nifi-extension-utils/nifi-prometheus-utils/pom.xml:
##########
@@ -53,6 +53,11 @@
<artifactId>nifi-metrics</artifactId>
<version>2.0.0-SNAPSHOT</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-framework-api</artifactId>
+ <version>2.0.0-SNAPSHOT</version>
+ </dependency>
Review Comment:
Thank @markap14 for your review. I've modified the code based on your recommendations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-12166 Add repo usage to the monitoring endpoint [nifi]
Posted by "timeabarna (via GitHub)" <gi...@apache.org>.
timeabarna commented on PR #7836:
URL: https://github.com/apache/nifi/pull/7836#issuecomment-1752337190
Thank @markap14 for your review. I've modified the code based on your recommendations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-12166 Add repo usage to the monitoring endpoint [nifi]
Posted by "markap14 (via GitHub)" <gi...@apache.org>.
markap14 commented on PR #7836:
URL: https://github.com/apache/nifi/pull/7836#issuecomment-1756053082
Thanks @timeabarna looks good to me. +1 will merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org