You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Oleg Nechiporenko <on...@apache.org> on 2017/02/09 10:09:55 UTC
Review Request 56485: Confusing Auto Start settings page behavior when
loading and API takes a while
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56485/
-----------------------------------------------------------
Review request for Ambari and Denys Buzhor.
Bugs: ambari-19934
https://issues.apache.org/jira/browse/ambari-19934
Repository: ambari
Description
-------
When the Admin > Auto Start settings page gets loaded and the API is taking a while, the behavior is really confusing.
It initially shows a checkbox that the user can click on. Upon clicking on it, it shows various Auto Start configs. But when the page fully loads, this whole section disappears, etc.
This is consistent with other pages that we have that depend on API results. For example, Admin > Kerberos page does not show any status/button but shows a spinner while the API call is in flight (other pages that follow this pattern are Admin > Stacks and Versions > Versions | Upgrade History, etc).
Since this is a new feature we are shipping, this page will receive some attention and the current behavior looks unpolished and confusing - does not inspire confidence.
Diffs
-----
ambari-web/app/templates/main/admin/service_auto_start.hbs 87fc915
ambari-web/app/views/main/admin/service_auto_start.js be928ed
Diff: https://reviews.apache.org/r/56485/diff/
Testing
-------
30312 passing (22s)
157 pending
Thanks,
Oleg Nechiporenko
Re: Review Request 56485: Confusing Auto Start settings page behavior
when loading and API takes a while
Posted by Denys Buzhor <bd...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56485/#review164890
-----------------------------------------------------------
Ship it!
Ship It!
- Denys Buzhor
On Feb. 9, 2017, 10:09 a.m., Oleg Nechiporenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56485/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2017, 10:09 a.m.)
>
>
> Review request for Ambari and Denys Buzhor.
>
>
> Bugs: ambari-19934
> https://issues.apache.org/jira/browse/ambari-19934
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When the Admin > Auto Start settings page gets loaded and the API is taking a while, the behavior is really confusing.
> It initially shows a checkbox that the user can click on. Upon clicking on it, it shows various Auto Start configs. But when the page fully loads, this whole section disappears, etc.
> This is consistent with other pages that we have that depend on API results. For example, Admin > Kerberos page does not show any status/button but shows a spinner while the API call is in flight (other pages that follow this pattern are Admin > Stacks and Versions > Versions | Upgrade History, etc).
>
> Since this is a new feature we are shipping, this page will receive some attention and the current behavior looks unpolished and confusing - does not inspire confidence.
>
>
> Diffs
> -----
>
> ambari-web/app/templates/main/admin/service_auto_start.hbs 87fc915
> ambari-web/app/views/main/admin/service_auto_start.js be928ed
>
> Diff: https://reviews.apache.org/r/56485/diff/
>
>
> Testing
> -------
>
> 30312 passing (22s)
> 157 pending
>
>
> Thanks,
>
> Oleg Nechiporenko
>
>