You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Kamesh <ka...@gmail.com> on 2014/12/15 18:02:02 UTC
Re: Patch Review
Can someone review these patches.
On Mon, Nov 17, 2014 at 10:44 PM, Kamesh <ka...@gmail.com> wrote:
>
> Please look into the following patches.
>
> DRILL-1502 <https://issues.apache.org/jira/browse/DRILL-1502>
>
> DRILL-1586 <https://issues.apache.org/jira/browse/DRILL-1586>
>
> --
> Kamesh.
>
--
Kamesh.
Re: Patch Review
Posted by Yash Sharma <ya...@gmail.com>.
Reviewed DRILL-1502: Can't connect to mongo when requiring auth
+1 - Tested on Sqlline.
--------------------------------------------------------------------------------------
Able to query mongo collection with mongo auth plugin with uid/pwd:
{
"type": "mongo",
"connection": "mongodb://admin:admin@localhost:27017/",
"enabled": true
}
--------------------------------------------------------------------------------------
Mongo Log:
2014-12-22T16:26:24.915+0530 [conn15] authenticate db: admin {
authenticate: 1, user: "admin", nonce: "xxx", key: "xxx" }
--------------------------------------------------------------------------------------
use mongo.newdb;
select x,y,z from newcollection limit 10;
+------------+------------+------------+
| x | y | z |
+------------+------------+------------+
| 1.0 | 1000.0 | 1.0 |
| 2.0 | 2000.0 | 4.0 |
| 3.0 | 3000.0 | 9.0 |
| 4.0 | 4000.0 | 16.0 |
| 5.0 | 5000.0 | 25.0 |
| 6.0 | 6000.0 | 36.0 |
| 7.0 | 7000.0 | 49.0 |
| 8.0 | 8000.0 | 64.0 |
| 9.0 | 9000.0 | 81.0 |
| 10.0 | 10000.0 | 100.0 |
+------------+------------+------------+
10 rows selected (0.151 seconds)
On Mon, Dec 15, 2014 at 10:32 PM, Kamesh <ka...@gmail.com> wrote:
> Can someone review these patches.
>
> On Mon, Nov 17, 2014 at 10:44 PM, Kamesh <ka...@gmail.com> wrote:
> >
> > Please look into the following patches.
> >
> > DRILL-1502 <https://issues.apache.org/jira/browse/DRILL-1502>
> >
> > DRILL-1586 <https://issues.apache.org/jira/browse/DRILL-1586>
> >
> > --
> > Kamesh.
> >
>
>
> --
> Kamesh.
>
Re: Patch Review
Posted by Yash Sharma <ya...@gmail.com>.
Reviewed DRILL-1586: NPE when the collection being queried for does not
exist in Mongo DB
+1.
Comments added to Review board.
On Mon, Dec 15, 2014 at 10:32 PM, Kamesh <ka...@gmail.com> wrote:
> Can someone review these patches.
>
> On Mon, Nov 17, 2014 at 10:44 PM, Kamesh <ka...@gmail.com> wrote:
> >
> > Please look into the following patches.
> >
> > DRILL-1502 <https://issues.apache.org/jira/browse/DRILL-1502>
> >
> > DRILL-1586 <https://issues.apache.org/jira/browse/DRILL-1586>
> >
> > --
> > Kamesh.
> >
>
>
> --
> Kamesh.
>