[GitHub] [tvm] Mousius commented on a diff in pull request #14483: [TOPI][Target] Add SVE specific convolution

["Mousius (via GitHub)" <gi...@apache.org>]

Mousius commented on code in PR #14483:
URL: https://github.com/apache/tvm/pull/14483#discussion_r1157002193


##########
src/target/parsers/aprofile.cc:
##########
@@ -112,6 +112,7 @@ static TargetFeatures GetFeatures(TargetJSON target) {
 
   bool simd_flag = HasFlag(mcpu, mattr, "+neon") || HasFlag(mcpu, mattr, "+simd");
   bool has_asimd = is_aarch64 || simd_flag;
+  const auto has_sve = HasFlag(mcpu, mattr, "+sve");

Review Comment:
   ```suggestion
     bool has_sve = HasFlag(mcpu, mattr, "+sve");
   ```
   
   For consistency with the rest of the file, I don't think `auto` adds anything here? 



##########
src/target/parsers/aprofile.cc:
##########
@@ -126,9 +127,8 @@ static TargetFeatures GetFeatures(TargetJSON target) {
   bool has_dotprod = (dotprod_default && !dotprod_disable) || (dotprod_support && dotprod_flag);
 
   return {
-      {"is_aarch64", Bool(is_aarch64)},
-      {"has_asimd", Bool(has_asimd)},
-      {"has_dotprod", Bool(has_dotprod)},
+      {"is_aarch64", Bool(is_aarch64)},  {"has_asimd", Bool(has_asimd)},
+      {"has_sve", Bool(has_sve)},        {"has_dotprod", Bool(has_dotprod)},

Review Comment:
   Tests please 😸 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org