[GitHub] [incubator-superset] etr2460 commented on issue #7987: [sqllab] Fix, API page size limit on database select box

[GitBox <gi...@apache.org>]

etr2460 commented on issue #7987: [sqllab] Fix, API page size limit on database select box
URL: https://github.com/apache/incubator-superset/pull/7987#issuecomment-518865090
 
 
   I think this should be reverted as it results in SQL errors trying to `LIMIT -1` when getting the list of databases in sql lab.
   
   By setting page_size to -1, we apply a limit on the query of -1 here in FAB: https://github.com/dpgaspar/Flask-AppBuilder/blob/master/flask_appbuilder/models/sqla/interface.py#L188
   
   @dpgaspar I think the required fix in FAB would be to 
   `return _page, None if _page_size == -1 else _page_size` 
   here: https://github.com/dpgaspar/Flask-AppBuilder/blob/2353b36fb611a6ffe2ca88637d0311a3c5c2a3ec/flask_appbuilder/api/__init__.py#L1518
   
   We might want to also revert the bump to FAB 2.1.8, or we could fix this forward. I leave that up to you

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org