You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Anshul Gangwar <an...@citrix.com> on 2014/06/20 12:21:24 UTC
Review Request 22807: CLOUDSTACK-6965: Fix for CLOUDSTACK-6935 introduces
the NullPointerException in ZoneWideStorageAllocator filter method
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22807/
-----------------------------------------------------------
Review request for cloudstack, Devdeep Singh, Rajesh Battala, and Sateesh Chodapuneedi.
Bugs: CLOUDSTACK-6965
https://issues.apache.org/jira/browse/CLOUDSTACK-6965
Repository: cloudstack-git
Description
-------
Fix for CLOUDSTACK-6935 has introduced the NullPointerException in code. Since ZoneWideStoragePoolAllocator's filter method has been removed it is using AbstractStoragePoolAllocator's filter method.
In the filter method there is check for cluster's hypervisor type and and disk profile hypervisor type.
But cluster is null for ZoneWideStoragePool and Hence the exception.
Diffs
-----
engine/storage/src/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java 2d958a6
Diff: https://reviews.apache.org/r/22807/diff/
Testing
-------
Thanks,
Anshul Gangwar
Re: Review Request 22807: CLOUDSTACK-6965: Fix for CLOUDSTACK-6935
introduces the NullPointerException in ZoneWideStorageAllocator filter method
Posted by Devdeep Singh <de...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22807/#review46389
-----------------------------------------------------------
Ship it!
Ship It!
- Devdeep Singh
On June 23, 2014, 5:30 a.m., Anshul Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22807/
> -----------------------------------------------------------
>
> (Updated June 23, 2014, 5:30 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh, Rajesh Battala, and Sateesh Chodapuneedi.
>
>
> Bugs: CLOUDSTACK-6965
> https://issues.apache.org/jira/browse/CLOUDSTACK-6965
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Fix for CLOUDSTACK-6935 has introduced the NullPointerException in code. Since ZoneWideStoragePoolAllocator's filter method has been removed it is using AbstractStoragePoolAllocator's filter method.
> In the filter method there is check for cluster's hypervisor type and and disk profile hypervisor type.
> But cluster is null for ZoneWideStoragePool and Hence the exception.
>
>
> Diffs
> -----
>
> engine/storage/src/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java 2d958a6
>
> Diff: https://reviews.apache.org/r/22807/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anshul Gangwar
>
>
Re: Review Request 22807: CLOUDSTACK-6965: Fix for CLOUDSTACK-6935
introduces the NullPointerException in ZoneWideStorageAllocator filter method
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22807/#review47175
-----------------------------------------------------------
Commit 1e72e5a818b7bcc738262a2b10794a17fbb0076b in cloudstack's branch refs/heads/master from ynojima
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=1e72e5a ]
CLOUDSTACK-6935 remove iSCSI storage filtering logic for Root volume
since there is no reason to filter it out
- ASF Subversion and Git Services
On June 23, 2014, 5:30 a.m., Anshul Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22807/
> -----------------------------------------------------------
>
> (Updated June 23, 2014, 5:30 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh, Rajesh Battala, and Sateesh Chodapuneedi.
>
>
> Bugs: CLOUDSTACK-6965
> https://issues.apache.org/jira/browse/CLOUDSTACK-6965
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Fix for CLOUDSTACK-6935 has introduced the NullPointerException in code. Since ZoneWideStoragePoolAllocator's filter method has been removed it is using AbstractStoragePoolAllocator's filter method.
> In the filter method there is check for cluster's hypervisor type and and disk profile hypervisor type.
> But cluster is null for ZoneWideStoragePool and Hence the exception.
>
>
> Diffs
> -----
>
> engine/storage/src/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java 2d958a6
>
> Diff: https://reviews.apache.org/r/22807/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anshul Gangwar
>
>
Re: Review Request 22807: CLOUDSTACK-6965: Fix for CLOUDSTACK-6935
introduces the NullPointerException in ZoneWideStorageAllocator filter method
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22807/#review46869
-----------------------------------------------------------
Commit 7959c1faf0828c0974de6d891d7685c2916122d7 in cloudstack's branch refs/heads/4.4-forward from Daan Hoogland
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=7959c1f ]
Revert "CLOUDSTACK-6935 refactor StoragePoolAllocator#filter logic"
This reverts commit 45f0c7367680f4bfbcee470139b708d69322be78.
- ASF Subversion and Git Services
On June 23, 2014, 5:30 a.m., Anshul Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22807/
> -----------------------------------------------------------
>
> (Updated June 23, 2014, 5:30 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh, Rajesh Battala, and Sateesh Chodapuneedi.
>
>
> Bugs: CLOUDSTACK-6965
> https://issues.apache.org/jira/browse/CLOUDSTACK-6965
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Fix for CLOUDSTACK-6935 has introduced the NullPointerException in code. Since ZoneWideStoragePoolAllocator's filter method has been removed it is using AbstractStoragePoolAllocator's filter method.
> In the filter method there is check for cluster's hypervisor type and and disk profile hypervisor type.
> But cluster is null for ZoneWideStoragePool and Hence the exception.
>
>
> Diffs
> -----
>
> engine/storage/src/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java 2d958a6
>
> Diff: https://reviews.apache.org/r/22807/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anshul Gangwar
>
>
Re: Review Request 22807: CLOUDSTACK-6965: Fix for CLOUDSTACK-6935
introduces the NullPointerException in ZoneWideStorageAllocator filter method
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22807/#review46383
-----------------------------------------------------------
Commit ef45f06f88c955dcf47f1fb69a3a0e87eb817e1d in cloudstack's branch refs/heads/4.4-forward from Anshul Gangwar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=ef45f06 ]
CLOUDSTACK-6965: fixed the NullPointerException introduced by fix for cloudstack
6935 in AbstractStoragePoolAllocator#filter method for Zone Wide storage
- ASF Subversion and Git Services
On June 23, 2014, 5:30 a.m., Anshul Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22807/
> -----------------------------------------------------------
>
> (Updated June 23, 2014, 5:30 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh, Rajesh Battala, and Sateesh Chodapuneedi.
>
>
> Bugs: CLOUDSTACK-6965
> https://issues.apache.org/jira/browse/CLOUDSTACK-6965
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Fix for CLOUDSTACK-6935 has introduced the NullPointerException in code. Since ZoneWideStoragePoolAllocator's filter method has been removed it is using AbstractStoragePoolAllocator's filter method.
> In the filter method there is check for cluster's hypervisor type and and disk profile hypervisor type.
> But cluster is null for ZoneWideStoragePool and Hence the exception.
>
>
> Diffs
> -----
>
> engine/storage/src/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java 2d958a6
>
> Diff: https://reviews.apache.org/r/22807/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anshul Gangwar
>
>
Re: Review Request 22807: CLOUDSTACK-6965: Fix for CLOUDSTACK-6935
introduces the NullPointerException in ZoneWideStorageAllocator filter method
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22807/#review46385
-----------------------------------------------------------
Commit bbcffbbab09905872a1b9c405a67734e457182fd in cloudstack's branch refs/heads/master from Anshul Gangwar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=bbcffbb ]
CLOUDSTACK-6965: fixed the NullPointerException introduced by fix for cloudstack
6935 in AbstractStoragePoolAllocator#filter method for Zone Wide storage
- ASF Subversion and Git Services
On June 23, 2014, 5:30 a.m., Anshul Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22807/
> -----------------------------------------------------------
>
> (Updated June 23, 2014, 5:30 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh, Rajesh Battala, and Sateesh Chodapuneedi.
>
>
> Bugs: CLOUDSTACK-6965
> https://issues.apache.org/jira/browse/CLOUDSTACK-6965
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Fix for CLOUDSTACK-6935 has introduced the NullPointerException in code. Since ZoneWideStoragePoolAllocator's filter method has been removed it is using AbstractStoragePoolAllocator's filter method.
> In the filter method there is check for cluster's hypervisor type and and disk profile hypervisor type.
> But cluster is null for ZoneWideStoragePool and Hence the exception.
>
>
> Diffs
> -----
>
> engine/storage/src/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java 2d958a6
>
> Diff: https://reviews.apache.org/r/22807/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anshul Gangwar
>
>
Re: Review Request 22807: CLOUDSTACK-6965: Fix for CLOUDSTACK-6935
introduces the NullPointerException in ZoneWideStorageAllocator filter method
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22807/#review46386
-----------------------------------------------------------
Commit 423c23af4052b29e908110d35978a4a720501448 in cloudstack's branch refs/heads/4.4 from Anshul Gangwar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=423c23a ]
CLOUDSTACK-6965: fixed the NullPointerException introduced by fix for cloudstack
6935 in AbstractStoragePoolAllocator#filter method for Zone Wide storage
(cherry picked from commit ef45f06f88c955dcf47f1fb69a3a0e87eb817e1d)
- ASF Subversion and Git Services
On June 23, 2014, 5:30 a.m., Anshul Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22807/
> -----------------------------------------------------------
>
> (Updated June 23, 2014, 5:30 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh, Rajesh Battala, and Sateesh Chodapuneedi.
>
>
> Bugs: CLOUDSTACK-6965
> https://issues.apache.org/jira/browse/CLOUDSTACK-6965
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Fix for CLOUDSTACK-6935 has introduced the NullPointerException in code. Since ZoneWideStoragePoolAllocator's filter method has been removed it is using AbstractStoragePoolAllocator's filter method.
> In the filter method there is check for cluster's hypervisor type and and disk profile hypervisor type.
> But cluster is null for ZoneWideStoragePool and Hence the exception.
>
>
> Diffs
> -----
>
> engine/storage/src/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java 2d958a6
>
> Diff: https://reviews.apache.org/r/22807/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anshul Gangwar
>
>
Re: Review Request 22807: CLOUDSTACK-6965: Fix for CLOUDSTACK-6935
introduces the NullPointerException in ZoneWideStorageAllocator filter method
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22807/#review46868
-----------------------------------------------------------
Commit 80f2694443e2795f289c95b10776285cc449f779 in cloudstack's branch refs/heads/4.4 from Daan Hoogland
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=80f2694 ]
Revert "CLOUDSTACK-6935 refactor StoragePoolAllocator#filter logic"
This reverts commit 99dd86e588fd28dedd5fb3b830297a8a4f885760.
- ASF Subversion and Git Services
On June 23, 2014, 5:30 a.m., Anshul Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22807/
> -----------------------------------------------------------
>
> (Updated June 23, 2014, 5:30 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh, Rajesh Battala, and Sateesh Chodapuneedi.
>
>
> Bugs: CLOUDSTACK-6965
> https://issues.apache.org/jira/browse/CLOUDSTACK-6965
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Fix for CLOUDSTACK-6935 has introduced the NullPointerException in code. Since ZoneWideStoragePoolAllocator's filter method has been removed it is using AbstractStoragePoolAllocator's filter method.
> In the filter method there is check for cluster's hypervisor type and and disk profile hypervisor type.
> But cluster is null for ZoneWideStoragePool and Hence the exception.
>
>
> Diffs
> -----
>
> engine/storage/src/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java 2d958a6
>
> Diff: https://reviews.apache.org/r/22807/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anshul Gangwar
>
>
Re: Review Request 22807: CLOUDSTACK-6965: Fix for CLOUDSTACK-6935
introduces the NullPointerException in ZoneWideStorageAllocator filter method
Posted by Anshul Gangwar <an...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22807/
-----------------------------------------------------------
(Updated June 23, 2014, 5:30 a.m.)
Review request for cloudstack, Devdeep Singh, Rajesh Battala, and Sateesh Chodapuneedi.
Changes
-------
updated the patch as per Devdeep's suggestion
Bugs: CLOUDSTACK-6965
https://issues.apache.org/jira/browse/CLOUDSTACK-6965
Repository: cloudstack-git
Description
-------
Fix for CLOUDSTACK-6935 has introduced the NullPointerException in code. Since ZoneWideStoragePoolAllocator's filter method has been removed it is using AbstractStoragePoolAllocator's filter method.
In the filter method there is check for cluster's hypervisor type and and disk profile hypervisor type.
But cluster is null for ZoneWideStoragePool and Hence the exception.
Diffs (updated)
-----
engine/storage/src/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java 2d958a6
Diff: https://reviews.apache.org/r/22807/diff/
Testing
-------
Thanks,
Anshul Gangwar
Re: Review Request 22807: CLOUDSTACK-6965: Fix for CLOUDSTACK-6935
introduces the NullPointerException in ZoneWideStorageAllocator filter method
Posted by Devdeep Singh <de...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22807/#review46268
-----------------------------------------------------------
engine/storage/src/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java
<https://reviews.apache.org/r/22807/#comment81579>
For a zone wide storage pool, the clusterId would be null. In that case you should check with the storage pool hypervisor type. A zone wide storage pool has a hypervisor field associated with it.
- Devdeep Singh
On June 20, 2014, 10:21 a.m., Anshul Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22807/
> -----------------------------------------------------------
>
> (Updated June 20, 2014, 10:21 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh, Rajesh Battala, and Sateesh Chodapuneedi.
>
>
> Bugs: CLOUDSTACK-6965
> https://issues.apache.org/jira/browse/CLOUDSTACK-6965
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Fix for CLOUDSTACK-6935 has introduced the NullPointerException in code. Since ZoneWideStoragePoolAllocator's filter method has been removed it is using AbstractStoragePoolAllocator's filter method.
> In the filter method there is check for cluster's hypervisor type and and disk profile hypervisor type.
> But cluster is null for ZoneWideStoragePool and Hence the exception.
>
>
> Diffs
> -----
>
> engine/storage/src/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java 2d958a6
>
> Diff: https://reviews.apache.org/r/22807/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anshul Gangwar
>
>