You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Alin Dreghiciu (JIRA)" <ji...@apache.org> on 2008/07/27 23:29:31 UTC
[jira] Created: (FELIX-648) Make system bundle export
org.osgi.service.permissionadmin/condpermadmin
Make system bundle export org.osgi.service.permissionadmin/condpermadmin
------------------------------------------------------------------------
Key: FELIX-648
URL: https://issues.apache.org/jira/browse/FELIX-648
Project: Felix
Issue Type: New Feature
Components: Framework
Reporter: Alin Dreghiciu
Priority: Trivial
As org.osgi.service.permissionadmin and condpermadmin package is part of core OSGi spec I'm thinking that the system bundle of Felix should also export those packages even if there is no actual service implementation of those services.
As an use case I have some bundles that import those packages (non optional) but those bundles could function if actual services are not present.
In order to this on the current code base is just a matter of changing the maven bundle plugin <Export-Package> to include this packages while building the framework bundle and add them to the property "org.osgi.framework.system.packages" in main/conf.properties. I can provide a patch if required.
As comparison, Equinox/Knopflerfish use the same approach. Export the packages but do not actually implement the service and I guess that Felix does not do that as there are no implementations of this services built in into framework. I guess that the other implementations provide those packages as they export all the packages from osgi core spec.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-648) Make system bundle export
org.osgi.service.permissionadmin/condpermadmin
Posted by "Marcel Offermans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617337#action_12617337 ]
Marcel Offermans commented on FELIX-648:
----------------------------------------
Karl actually has an implementation of PA and CPA (and I helped out a bit). This is done as a framework extension, so you can simply plug it in. When you do that, the packages are made available too. I would prefer that you simply provide those packages yourself instead of adding them to the framework, or rewrite your bundle to detect if PA/CPA are present without actually having to import them (as an example of that, look at the core framework and how it "discovers" a log service in that way).
> Make system bundle export org.osgi.service.permissionadmin/condpermadmin
> ------------------------------------------------------------------------
>
> Key: FELIX-648
> URL: https://issues.apache.org/jira/browse/FELIX-648
> Project: Felix
> Issue Type: New Feature
> Components: Framework
> Reporter: Alin Dreghiciu
> Priority: Trivial
>
> As org.osgi.service.permissionadmin and condpermadmin package is part of core OSGi spec I'm thinking that the system bundle of Felix should also export those packages even if there is no actual service implementation of those services.
> As an use case I have some bundles that import those packages (non optional) but those bundles could function if actual services are not present.
> In order to this on the current code base is just a matter of changing the maven bundle plugin <Export-Package> to include this packages while building the framework bundle and add them to the property "org.osgi.framework.system.packages" in main/conf.properties. I can provide a patch if required.
> As comparison, Equinox/Knopflerfish use the same approach. Export the packages but do not actually implement the service and I guess that Felix does not do that as there are no implementations of this services built in into framework. I guess that the other implementations provide those packages as they export all the packages from osgi core spec.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (FELIX-648) Make system bundle export
org.osgi.service.permissionadmin/condpermadmin
Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Richard S. Hall resolved FELIX-648.
-----------------------------------
Resolution: Won't Fix
I am resolving this as "Won't Fix"...Alin please close if you can accept it, otherwise re-open it and we can continue to argue about it another day. :-)
> Make system bundle export org.osgi.service.permissionadmin/condpermadmin
> ------------------------------------------------------------------------
>
> Key: FELIX-648
> URL: https://issues.apache.org/jira/browse/FELIX-648
> Project: Felix
> Issue Type: New Feature
> Components: Framework
> Reporter: Alin Dreghiciu
> Priority: Trivial
>
> As org.osgi.service.permissionadmin and condpermadmin package is part of core OSGi spec I'm thinking that the system bundle of Felix should also export those packages even if there is no actual service implementation of those services.
> As an use case I have some bundles that import those packages (non optional) but those bundles could function if actual services are not present.
> In order to this on the current code base is just a matter of changing the maven bundle plugin <Export-Package> to include this packages while building the framework bundle and add them to the property "org.osgi.framework.system.packages" in main/conf.properties. I can provide a patch if required.
> As comparison, Equinox/Knopflerfish use the same approach. Export the packages but do not actually implement the service and I guess that Felix does not do that as there are no implementations of this services built in into framework. I guess that the other implementations provide those packages as they export all the packages from osgi core spec.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-648) Make system bundle export
org.osgi.service.permissionadmin/condpermadmin
Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617345#action_12617345 ]
Richard S. Hall commented on FELIX-648:
---------------------------------------
I am in agreement with Marcel, this doesn't seem like a good idea to me. The whole idea of OSGi is to be modular and only include what you need and/or use. So, it doesn't make sense to me to start rolling things into the main JAR just because some people might use it. If you use something like OBR, it will automatically pull in compendium to resolve these dependencies. And as you point Alin, even marking your imports as optional (or dynamic) is a reasonable approach, which might make more sense here because you are capturing the true nature of your bundle's dependency on these packages, it is optional not mandatory to have them available.
> Make system bundle export org.osgi.service.permissionadmin/condpermadmin
> ------------------------------------------------------------------------
>
> Key: FELIX-648
> URL: https://issues.apache.org/jira/browse/FELIX-648
> Project: Felix
> Issue Type: New Feature
> Components: Framework
> Reporter: Alin Dreghiciu
> Priority: Trivial
>
> As org.osgi.service.permissionadmin and condpermadmin package is part of core OSGi spec I'm thinking that the system bundle of Felix should also export those packages even if there is no actual service implementation of those services.
> As an use case I have some bundles that import those packages (non optional) but those bundles could function if actual services are not present.
> In order to this on the current code base is just a matter of changing the maven bundle plugin <Export-Package> to include this packages while building the framework bundle and add them to the property "org.osgi.framework.system.packages" in main/conf.properties. I can provide a patch if required.
> As comparison, Equinox/Knopflerfish use the same approach. Export the packages but do not actually implement the service and I guess that Felix does not do that as there are no implementations of this services built in into framework. I guess that the other implementations provide those packages as they export all the packages from osgi core spec.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-648) Make system bundle export
org.osgi.service.permissionadmin/condpermadmin
Posted by "Alin Dreghiciu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617338#action_12617338 ]
Alin Dreghiciu commented on FELIX-648:
--------------------------------------
I could find workarounds for my case. In this case just adding the resolution:=optional will suffice.
Just curious what are the consideration to not include them as the other frameworks? Size? I made the change locally and the difference is 16kb.
I always had the impression that I can rely on the framework implementation to export all the packages defined in the core specs.
Anyhow is not an hard issue.
> Make system bundle export org.osgi.service.permissionadmin/condpermadmin
> ------------------------------------------------------------------------
>
> Key: FELIX-648
> URL: https://issues.apache.org/jira/browse/FELIX-648
> Project: Felix
> Issue Type: New Feature
> Components: Framework
> Reporter: Alin Dreghiciu
> Priority: Trivial
>
> As org.osgi.service.permissionadmin and condpermadmin package is part of core OSGi spec I'm thinking that the system bundle of Felix should also export those packages even if there is no actual service implementation of those services.
> As an use case I have some bundles that import those packages (non optional) but those bundles could function if actual services are not present.
> In order to this on the current code base is just a matter of changing the maven bundle plugin <Export-Package> to include this packages while building the framework bundle and add them to the property "org.osgi.framework.system.packages" in main/conf.properties. I can provide a patch if required.
> As comparison, Equinox/Knopflerfish use the same approach. Export the packages but do not actually implement the service and I guess that Felix does not do that as there are no implementations of this services built in into framework. I guess that the other implementations provide those packages as they export all the packages from osgi core spec.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-648) Make system bundle export
org.osgi.service.permissionadmin/condpermadmin
Posted by "Marcel Offermans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617340#action_12617340 ]
Marcel Offermans commented on FELIX-648:
----------------------------------------
First of all, I'm just voicing my opinion, but size would be my main argument for not including them by default. But to be honest, there are many different packaging strategies, and many different opinions. A practical solution is to roll your own distribution. Personally I see the felix.jar as just one example of packaging Felix with a launcher. That launcher, the contents of the JAR, and the way it is configured for sure are not ideal in all cases.
> Make system bundle export org.osgi.service.permissionadmin/condpermadmin
> ------------------------------------------------------------------------
>
> Key: FELIX-648
> URL: https://issues.apache.org/jira/browse/FELIX-648
> Project: Felix
> Issue Type: New Feature
> Components: Framework
> Reporter: Alin Dreghiciu
> Priority: Trivial
>
> As org.osgi.service.permissionadmin and condpermadmin package is part of core OSGi spec I'm thinking that the system bundle of Felix should also export those packages even if there is no actual service implementation of those services.
> As an use case I have some bundles that import those packages (non optional) but those bundles could function if actual services are not present.
> In order to this on the current code base is just a matter of changing the maven bundle plugin <Export-Package> to include this packages while building the framework bundle and add them to the property "org.osgi.framework.system.packages" in main/conf.properties. I can provide a patch if required.
> As comparison, Equinox/Knopflerfish use the same approach. Export the packages but do not actually implement the service and I guess that Felix does not do that as there are no implementations of this services built in into framework. I guess that the other implementations provide those packages as they export all the packages from osgi core spec.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.