You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Nihal Jain (Jira)" <ji...@apache.org> on 2024/09/20 16:14:00 UTC

[jira] [Comment Edited] (HBASE-28868) Add missing permission check for updateRSGroupConfig in branch-2

    [ https://issues.apache.org/jira/browse/HBASE-28868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883319#comment-17883319 ] 

Nihal Jain edited comment on HBASE-28868 at 9/20/24 4:13 PM:
-------------------------------------------------------------

Even though the check is missing, the method invocation will still fail for a non privileged user as we do a ADMIN check in {{{}rpcPreCheck("execMasterService"){}}}, so technically this is not a security issue. See [https://github.com/apache/hbase/blob/0dc334f572329be7eb2455cec3519fc820c04c25/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java#L905]


was (Author: nihaljain.cs):
Even though the check is missing, the method invocation will still fail as we do a ADMIN check in {{rpcPreCheck("execMasterService")}}, so technically this is not a security issue. See [https://github.com/apache/hbase/blob/0dc334f572329be7eb2455cec3519fc820c04c25/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java#L905]

> Add missing permission check for updateRSGroupConfig in branch-2
> ----------------------------------------------------------------
>
>                 Key: HBASE-28868
>                 URL: https://issues.apache.org/jira/browse/HBASE-28868
>             Project: HBase
>          Issue Type: Task
>          Components: rsgroup
>    Affects Versions: 2.7.0
>            Reporter: Nihal Jain
>            Assignee: Nihal Jain
>            Priority: Minor
>              Labels: pull-request-available
>
> Found this during HBASE-28867, we do not have security check for updateRSGroupConfig in branch-2. See [https://github.com/apache/hbase/blob/0dc334f572329be7eb2455cec3519fc820c04c25/hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminEndpoint.java#L450]
> Same check exists in master [https://github.com/apache/hbase/blob/52082bc5b80a60406bfaaa630ed5cb23027436c1/hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java#L2279]
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)