You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/14 22:26:42 UTC
[GitHub] [arrow-rs] alamb opened a new pull request, #3112: Remove dangling tests
alamb opened a new pull request, #3112:
URL: https://github.com/apache/arrow-rs/pull/3112
# Which issue does this PR close?
re https://github.com/apache/arrow-rs/issues/3045
# Rationale for this change
When trying to release arrow 27.0.0 using `(cd arrow && cargo release)` I got the following errors until I removed these entries:
```
error: failed to verify package tarball
Caused by:
failed to parse manifest at `/Users/alamb/Downloads/apache-arrow-rs-27.0.0/arrow/target/package/arrow-27.0.0/Cargo.toml`
Caused by:
can't find `ipc` test at `tests/ipc.rs` or `tests/ipc/main.rs`. Please specify test.path if you want to use a non-default path.
error: failed to verify package tarball
Caused by:
failed to parse manifest at `/Users/alamb/Downloads/apache-arrow-rs-27.0.0/arrow/target/package/arrow-27.0.0/Cargo.toml`
Caused by:
can't find `csv` test at `tests/csv.rs` or `tests/csv/main.rs`. Please specify test.path if you want to use a non-default path.
```
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #3112: Remove dangling `csv` and `ipc` tests in `arrow/Cargo.toml`
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #3112:
URL: https://github.com/apache/arrow-rs/pull/3112#issuecomment-1315799860
I plan to look at this one later (before the next release) but don't have the time to devote to tracking it down now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #3112: Remove dangling `csv` and `ipc` tests in `arrow/Cargo.toml`
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #3112:
URL: https://github.com/apache/arrow-rs/pull/3112#issuecomment-1317495246
Marking as a draft until I have this sorted out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #3112: Remove dangling `csv` and `ipc` tests in `arrow/Cargo.toml`
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #3112:
URL: https://github.com/apache/arrow-rs/pull/3112#issuecomment-1327833473
New proposal https://github.com/apache/arrow-rs/pull/3196
(basically I did what @tustvold suggested)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb closed pull request #3112: Remove dangling `csv` and `ipc` tests in `arrow/Cargo.toml`
Posted by GitBox <gi...@apache.org>.
alamb closed pull request #3112: Remove dangling `csv` and `ipc` tests in `arrow/Cargo.toml`
URL: https://github.com/apache/arrow-rs/pull/3112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #3112: Remove dangling `csv` and `ipc` tests in `arrow/Cargo.toml`
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #3112:
URL: https://github.com/apache/arrow-rs/pull/3112#issuecomment-1327794444
Drat -- I didn't sort this out in time for the release -- I'll do it while waiting for some of this release to go out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #3112: Remove dangling `csv` and `ipc` tests in `arrow/Cargo.toml`
Posted by GitBox <gi...@apache.org>.
tustvold commented on PR #3112:
URL: https://github.com/apache/arrow-rs/pull/3112#issuecomment-1314608674
I wonder if the issue is the `include` directive excludes the integration tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org