[GitHub] [incubator-iceberg] rdsr commented on a change in pull request #101: Add length to FileAppender to avoid a call to S3 when writing.

[GitBox <gi...@apache.org>]

rdsr commented on a change in pull request #101: Add length to FileAppender to avoid a call to S3 when writing.
URL: https://github.com/apache/incubator-iceberg/pull/101#discussion_r266303175
 
 

 ##########
 File path: core/src/main/java/com/netflix/iceberg/avro/AvroFileAppender.java
 ##########
 @@ -56,6 +59,18 @@ public Metrics metrics() {
     return new Metrics(numRecords, null, null, null);
   }
 
+  @Override
+  public long length() {
+    if (stream != null) {
 
 Review comment:
   The API make the contract that this is valid only when the file is closed. Would it make sense to check that in Avro and Orc file appenders?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org