You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by ji...@apache.org on 2021/09/13 05:55:42 UTC
[rocketmq] branch develop updated: [ISSUE #3346]Avoid double parse
remoteAddr in rpcHook call
This is an automated email from the ASF dual-hosted git repository.
jinrongtong pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new 83b04d0 [ISSUE #3346]Avoid double parse remoteAddr in rpcHook call
83b04d0 is described below
commit 83b04d03f62b1178c5d8a0a41a67fe08d350e081
Author: WJL3333 <wj...@163.com>
AuthorDate: Mon Sep 13 13:55:35 2021 +0800
[ISSUE #3346]Avoid double parse remoteAddr in rpcHook call
---
.../org/apache/rocketmq/remoting/netty/NettyRemotingAbstract.java | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingAbstract.java b/remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingAbstract.java
index c9b3994..b2e7294 100644
--- a/remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingAbstract.java
+++ b/remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingAbstract.java
@@ -199,11 +199,12 @@ public abstract class NettyRemotingAbstract {
@Override
public void run() {
try {
- doBeforeRpcHooks(RemotingHelper.parseChannelRemoteAddr(ctx.channel()), cmd);
+ String remoteAddr = RemotingHelper.parseChannelRemoteAddr(ctx.channel());
+ doBeforeRpcHooks(remoteAddr, cmd);
final RemotingResponseCallback callback = new RemotingResponseCallback() {
@Override
public void callback(RemotingCommand response) {
- doAfterRpcHooks(RemotingHelper.parseChannelRemoteAddr(ctx.channel()), cmd, response);
+ doAfterRpcHooks(remoteAddr, cmd, response);
if (!cmd.isOnewayRPC()) {
if (response != null) {
response.setOpaque(opaque);