You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "Kenneth Knowles (JIRA)" <ji...@apache.org> on 2018/01/21 23:43:00 UTC
[jira] [Assigned] (BEAM-3332) AfterProcessingTimer trigger not
firing if invoked exactly on time
[ https://issues.apache.org/jira/browse/BEAM-3332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kenneth Knowles reassigned BEAM-3332:
-------------------------------------
Assignee: Shen Li (was: Kenneth Knowles)
> AfterProcessingTimer trigger not firing if invoked exactly on time
> ------------------------------------------------------------------
>
> Key: BEAM-3332
> URL: https://issues.apache.org/jira/browse/BEAM-3332
> Project: Beam
> Issue Type: Bug
> Components: runner-core
> Affects Versions: 2.0.0, 2.1.0, 2.2.0
> Reporter: Shen Li
> Assignee: Shen Li
> Priority: Trivial
> Fix For: 2.3.0
>
>
> I occasionally run into an issue that the processing time trigger is invoked on time, but the TriggerStateMachienRunner#shouldFire() returns false. After comparing time instances, I found that this issue occurs when the trigger is invoked exactly on time. It is because the AfterDelayFromFirstElementStateMachine does the following:
> {quote} return delayedUntil != null
> && getCurrentTime(context) != null
> && getCurrentTime(context).isAfter(delayedUntil);{quote}
> which only returns true when the current processing time is AFTER (exclude equals) delayUntil. Should it actually be !getCurrentTime(context).isBefore(delayedUntil) ?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)