You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by ph...@apache.org on 2015/03/23 13:33:22 UTC
svn commit: r1668618 -
/subversion/trunk/subversion/bindings/swig/include/svn_types.swg
Author: philip
Date: Mon Mar 23 12:33:22 2015
New Revision: 1668618
URL: http://svn.apache.org/r1668618
Log:
* subversion/bindings/swig/include/svn_types.swg: Change the
SWIG Perl binding code that was marked "clearly buggy" so
that svn_swig_pl_from_md5 follows the same pattern as
svn_swig_pl_from_stream. This may fix a SEGV reported
via Debian: https://bugs.debian.org/780246
Modified:
subversion/trunk/subversion/bindings/swig/include/svn_types.swg
Modified: subversion/trunk/subversion/bindings/swig/include/svn_types.swg
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/bindings/swig/include/svn_types.swg?rev=1668618&r1=1668617&r2=1668618&view=diff
==============================================================================
--- subversion/trunk/subversion/bindings/swig/include/svn_types.swg (original)
+++ subversion/trunk/subversion/bindings/swig/include/svn_types.swg Mon Mar 23 12:33:22 2015
@@ -1116,11 +1116,7 @@ svn_ ## TYPE ## _swig_rb_closed(VALUE se
}
%typemap(argout) unsigned char *result_digest {
- /* FIXME: This code is clearly buggy. The return value of sv_newmortal()
- is immediately overwritten by the return value
- of svn_swig_pl_from_md5(). */
- ST(argvi) = sv_newmortal();
- ST(argvi++) = svn_swig_pl_from_md5($1);
+ %append_output(svn_swig_pl_from_md5($1));
}
#endif