You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/09/07 09:57:30 UTC

[GitHub] [flink] zentol opened a new pull request #17181: [FLINK-24183][legal] Add aws-java-sdk-s3 to source NOTICE

zentol opened a new pull request #17181:
URL: https://github.com/apache/flink/pull/17181


   Adds the aws-java-sdk NOTICE to the source NOTICE, because we have copied classes from said project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol merged pull request #17181: [FLINK-24183][legal] Add aws-java-sdk-s3 to source NOTICE

Posted by GitBox <gi...@apache.org>.
zentol merged pull request #17181:
URL: https://github.com/apache/flink/pull/17181


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #17181: [FLINK-24183][legal] Add aws-java-sdk-s3 to source NOTICE

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17181:
URL: https://github.com/apache/flink/pull/17181#issuecomment-914199555


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5f878ab2ac0686e0f08d314ae83025e8077e6a55",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "5f878ab2ac0686e0f08d314ae83025e8077e6a55",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5f878ab2ac0686e0f08d314ae83025e8077e6a55 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] dmvk commented on a change in pull request #17181: [FLINK-24183][legal] Add aws-java-sdk-s3 to source NOTICE

Posted by GitBox <gi...@apache.org>.
dmvk commented on a change in pull request #17181:
URL: https://github.com/apache/flink/pull/17181#discussion_r704124241



##########
File path: NOTICE
##########
@@ -43,3 +43,22 @@ The Apache Flink project contains or reuses code that is licensed under the Apac
 - Google Cloud Client Library for Java (https://github.com/googleapis/google-cloud-java) Copyright 2017 Google LLC
 
   See: flink-end-to-end-tests/flink-connector-gcp-pubsub-emulator-tests/src/test/java/org/apache/flink/streaming/connectors/gcp/pubsub/emulator/PubsubHelper.java
+
+- aws-sdk-java-s3 (https://github.com/aws/aws-sdk-java)
+
+  See: flink/flink-filesystems/flink-s3-fs-base/src/main/java/com/amazonaws/services/s3/model/transform/XmlResponsesSaxParser.java
+
+AWS SDK for Java
+Copyright 2010-2014 Amazon.com, Inc. or its affiliates. All Rights Reserved.
+
+This product includes software developed by
+Amazon Technologies, Inc (http://www.amazon.com/).
+
+**********************
+THIRD PARTY COMPONENTS
+**********************

Review comment:
       I was puzzled where you get this and it's just a copy paste from the library's notice file 👍 
   
   https://github.com/aws/aws-sdk-java/blob/master/NOTICE.txt




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17181: [FLINK-24183][legal] Add aws-java-sdk-s3 to source NOTICE

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17181:
URL: https://github.com/apache/flink/pull/17181#issuecomment-914199555


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5f878ab2ac0686e0f08d314ae83025e8077e6a55",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23688",
       "triggerID" : "5f878ab2ac0686e0f08d314ae83025e8077e6a55",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5f878ab2ac0686e0f08d314ae83025e8077e6a55 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23688) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #17181: [FLINK-24183][legal] Add aws-java-sdk-s3 to source NOTICE

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17181:
URL: https://github.com/apache/flink/pull/17181#issuecomment-914169737


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 5f878ab2ac0686e0f08d314ae83025e8077e6a55 (Tue Sep 07 10:00:43 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] dmvk commented on a change in pull request #17181: [FLINK-24183][legal] Add aws-java-sdk-s3 to source NOTICE

Posted by GitBox <gi...@apache.org>.
dmvk commented on a change in pull request #17181:
URL: https://github.com/apache/flink/pull/17181#discussion_r704124241



##########
File path: NOTICE
##########
@@ -43,3 +43,22 @@ The Apache Flink project contains or reuses code that is licensed under the Apac
 - Google Cloud Client Library for Java (https://github.com/googleapis/google-cloud-java) Copyright 2017 Google LLC
 
   See: flink-end-to-end-tests/flink-connector-gcp-pubsub-emulator-tests/src/test/java/org/apache/flink/streaming/connectors/gcp/pubsub/emulator/PubsubHelper.java
+
+- aws-sdk-java-s3 (https://github.com/aws/aws-sdk-java)
+
+  See: flink/flink-filesystems/flink-s3-fs-base/src/main/java/com/amazonaws/services/s3/model/transform/XmlResponsesSaxParser.java
+
+AWS SDK for Java
+Copyright 2010-2014 Amazon.com, Inc. or its affiliates. All Rights Reserved.
+
+This product includes software developed by
+Amazon Technologies, Inc (http://www.amazon.com/).
+
+**********************
+THIRD PARTY COMPONENTS
+**********************

Review comment:
       I was puzzled where you got this and it's just a copy paste from the library's notice file 👍 
   
   https://github.com/aws/aws-sdk-java/blob/master/NOTICE.txt




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17181: [FLINK-24183][legal] Add aws-java-sdk-s3 to source NOTICE

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17181:
URL: https://github.com/apache/flink/pull/17181#issuecomment-914199555


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5f878ab2ac0686e0f08d314ae83025e8077e6a55",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23688",
       "triggerID" : "5f878ab2ac0686e0f08d314ae83025e8077e6a55",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5f878ab2ac0686e0f08d314ae83025e8077e6a55 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23688) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org