You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "viirya (via GitHub)" <gi...@apache.org> on 2023/09/07 20:52:21 UTC
[GitHub] [arrow-datafusion-python] viirya opened a new pull request, #471: Add isnan
viirya opened a new pull request, #471:
URL: https://github.com/apache/arrow-datafusion-python/pull/471
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
Adding `isnan` scalar function which exists in Rust library.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] viirya commented on pull request #471: Add isnan scalar function
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #471:
URL: https://github.com/apache/arrow-datafusion-python/pull/471#issuecomment-1710760377
CI seems broken: https://github.com/apache/arrow-datafusion-python/issues/472
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] viirya closed pull request #471: Add isnan scalar function
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya closed pull request #471: Add isnan scalar function
URL: https://github.com/apache/arrow-datafusion-python/pull/471
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] viirya commented on pull request #471: Add isnan scalar function
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #471:
URL: https://github.com/apache/arrow-datafusion-python/pull/471#issuecomment-1714303491
Close this as there is first time contributor's work #495. This is good first issue so it should be better to let new contributor work on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] viirya commented on pull request #471: Add isnan scalar function
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #471:
URL: https://github.com/apache/arrow-datafusion-python/pull/471#issuecomment-1710805395
CI should be fixed by https://github.com/apache/arrow-datafusion-python/pull/474
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] viirya commented on a diff in pull request #471: Add isnan scalar function
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #471:
URL: https://github.com/apache/arrow-datafusion-python/pull/471#discussion_r1320080768
##########
src/functions.rs:
##########
@@ -247,7 +248,7 @@ scalar_function!(
scalar_function!(
nanvl,
Nanvl,
- "Computes the MD5 hash of the argument, with the result written in hexadecimal."
Review Comment:
This function description was copied from MD5 previously, I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] viirya commented on pull request #471: Add isnan scalar function
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #471:
URL: https://github.com/apache/arrow-datafusion-python/pull/471#issuecomment-1711980288
Ah, this repos still uses 29.0.0.
Changed to draft until this upgrades to latest DataFusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org