[GitHub] [pinot] walterddr commented on a diff in pull request #9811: [Multistage][Testing] Integration test for general aggregate functions.

[GitBox <gi...@apache.org>]

walterddr commented on code in PR #9811:
URL: https://github.com/apache/pinot/pull/9811#discussion_r1024186620


##########
pinot-query-runtime/src/test/resources/queries/Aggregates.json:
##########
@@ -0,0 +1,295 @@
+{
+  "general_aggregate": {
+    "tables": {
+      "tbl": {
+        "schema": [
+          {
+            "name": "int_col",
+            "type": "INT"
+          },
+          {
+            "name": "double_col",
+            "type": "DOUBLE"
+          },
+          {
+            "name": "string_col",
+            "type": "STRING"
+          }
+        ],
+        "inputs": [

Review Comment:
   nit: can't we make the inputs and schemas one line cross? makes it easier to read instead of the auto-formatting
   
   I will create a codestyle XML changes for JSON type from "always wrap" to "wrap if too long"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org